Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update connection_manager.py #230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

herrek1
Copy link

@herrek1 herrek1 commented Dec 12, 2024

added missing f string in assert condition of oracledb db_module

added missing f string in assert condition of oracledb db_module
@herrek1
Copy link
Author

herrek1 commented Dec 12, 2024

Parameter "oracle_thin_mode" is not resolved without f string at the beginning of the line 467

@amochin amochin added this to the next_version milestone Dec 13, 2024
@amochin
Copy link
Collaborator

amochin commented Dec 13, 2024

Good catch @herrek1, thanks for your contribution!
I'll merge it in the next bug fix release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants