Skip to content

Support SAP HANA via ODBC - using "SERVERNODE" parameter in connection string #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Support SAP HANA via ODBC - using "SERVERNODE" parameter in connection string #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4aa0fce
Change server string in ODBC Driver for SAPHANA
RaffaeleDV Feb 10, 2025
b30c6e4
Merge pull request #235 from RaffaeleDV/support-to-saphana
amochin Feb 10, 2025
e9d25a2
Proper parameters for SAP HANA
amochin Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,10 @@
"--output", "${workspaceRoot}/logs/interactive_console.xml"
],
"python.analysis.completeFunctionParens": true,
"cSpell.words": [
"hana",
"hdbodbc",
"saphana",
"SERVERNODE"
],
}
12 changes: 8 additions & 4 deletions src/DatabaseLibrary/connection_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,10 +391,14 @@ def _arg_or_config(arg_value, param_name, *, old_param_name=None, mandatory=Fals
if db_charset:
con_str += f"charset={db_charset};"
if db_host and db_port:
if odbc_driver and "mysql" in odbc_driver.lower():
con_str += f"SERVER={db_host}:{db_port};"
else:
con_str += f"SERVER={db_host},{db_port};"
con_str_server = f"SERVER={db_host},{db_port};" # default for most databases
if odbc_driver:
driver_lower = odbc_driver.lower()
if "mysql" in driver_lower:
con_str_server = f"SERVER={db_host}:{db_port};"
elif "saphana" in driver_lower or "hdbodbc" in driver_lower or "sap hana" in driver_lower:
con_str_server = f"SERVERNODE={db_host}:{db_port};"
con_str += con_str_server

for param_name, param_value in custom_connection_params.items():
con_str += f"{param_name}={param_value};"
Expand Down