fixed #2513 list getters always shall return lists

Signed-off-by: René <snooz@posteo.de>
MarketSquare · Jan 6, 2023 · 5c409e3 · 5c409e3
1 parent f047121
commit 5c409e3
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/Browser/requirements.txt b/Browser/requirements.txt
@@ -4,7 +4,7 @@ grpcio-tools == 1.51.1
 protobuf==4.21.12
 robotframework >=4.1.3
 robotframework-pythonlibcore >= 4.0.0
-robotframework-assertion-engine >= 0.6.1
+robotframework-assertion-engine >= 1.0.0
 typing-extensions >= 4.4.0
 wrapt >= 1.14.1
 overrides >= 7.3.1
diff --git a/atest/test/02_Content_Keywords/basic_getters.robot b/atest/test/02_Content_Keywords/basic_getters.robot
@@ -125,7 +125,7 @@ Get Classes With Strict
     ...    Get Classes    //button
     Set Strict Mode    False
     ${classes} =    Get Classes    //button
-    Should Be Equal    ${classes}    ${None}
+    Should Be Equal    ${classes}    ${{[]}}
     [Teardown]    Set Strict Mode    True
 
 Get Classes And Assert

diff --git a/atest/test/02_Content_Keywords/basic_getters_expect_errors.robot b/atest/test/02_Content_Keywords/basic_getters_expect_errors.robot
@@ -215,21 +215,21 @@ Get Attribute Names Default Error
     ${expected} =    Create List    1    3
     Run Keyword And Expect Error
     ...    Attribute names '*' (list) should be '?'1', '3'?' (list)
-    ...    Get Attribute Names    [name="readonly_input"]    ==    ${expected}
+    ...    Get Attribute Names    [name="readonly_input"]    ==    @{expected}
     [Teardown]    Close Page
 
 Get Attribute Names Custom Error
     [Setup]    New Page    ${ELEMENT_STATE_URL}
     ${expected} =    Create List    1    3
     Run Keyword And Expect Error    Custom error ?'1', '3'? list    Get Attribute Names    [name="readonly_input"]
-    ...    ==    ${expected}    message=Custom error {expected} {expected_type}
+    ...    ==    @{expected}    message=Custom error {expected} {expected_type}
     Run Keyword And Expect Error    Custom error ?'1', '3'? list    Get Attribute Names    [name="readonly_input"]
     ...    ==    1    3    message=Custom error {expected} {expected_type}
     [Teardown]    Close Page
 
 Get Classes Default Error
     Run Keyword And Expect Error
-    ...    Classes of ${SELECTOR_PREFIX_SPACED}id=draggable '[[]'box', 'react-draggable'[]]' (list) should contain 'not-here' (str)
+    ...    EQUALS: Classes of ${SELECTOR_PREFIX_SPACED}id=draggable '['box', 'react-draggable']' (list) should contain '['not-here']' (list)
     ...    Get Classes
     ...    id=draggable
     ...    contains

diff --git a/atest/test/02_Content_Keywords/select_lists.robot b/atest/test/02_Content_Keywords/select_lists.robot
@@ -37,7 +37,7 @@ Get Selected Options
     ...    Verifying list 'possible_channels' fails if assert all options selected.
     [Tags]    slow
     ${selection} =    Get Selected Options    select[name=preferred_channel]    label    ==    Telephone
-    Should Be Equal    ${selection}    Telephone
+    Should Be Equal    ${selection}    ${{["Telephone"]}}
     Get Selected Options    select[name=preferred_channel]    value    ==    phone
     Get Selected Options    select[name=possible_channels]    text    ==    Email    Telephone
     Get Selected Options    select[name=possible_channels]    text    validate    len(value) == 2
@@ -47,14 +47,14 @@ Get Selected Options
     Should Be Equal    ${selection}[1]    phone
     Get Selected Options    select[name=interests]    label    ==
     ${selection} =    Get Selected Options    select[name=interests]    label    ==
-    Should Be Equal    ${selection}    ${None}
+    Should Be Equal    ${selection}    ${{[]}}
     Run Keyword And Expect Error    *    Get Selected Options    select[name=possible_channels]    label    ==
     ...    Email    Telephone    Direct mail
 
 Get Selected Options With Not Matching Attribute Value
     [Tags]    slow
     Run Keyword And Expect Error
-    ...    Selected Options: 'phone' (str) should be 'kala' (str)
+    ...    EQUALS: Selected Options: '['phone']' (list) should be '['kala']' (list)
     ...    Get Selected Options    select[name=preferred_channel]    value    ==    kala
 
 Get Select Options With Not Matching Value
@@ -66,7 +66,7 @@ Get Select Options With Not Matching Value
 Get Selected Options With Xpath
     ${selection} =    Get Selected Options    //html/body/form/table/tbody/tr[8]/td[2]/select    label    ==
     ...    Telephone
-    Should Be Equal    ${selection}    Telephone
+    Should Be Equal    ${selection}    ${{["Telephone"]}}
 
 Get Selected Options With Nonmatching Selector
     [Tags]    no-iframe