Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic/argument docs #2308

Merged
merged 10 commits into from
Sep 20, 2022
Merged

Topic/argument docs #2308

merged 10 commits into from
Sep 20, 2022

Conversation

Snooz82
Copy link
Member

@Snooz82 Snooz82 commented Sep 18, 2022 •
edited
Loading

News & Changes:

Following should be backwards compatible:

  • Deprecation of positional arguments for Library Import and New Context
  • Deprecated positional arguments except the first few of New Browser and New Persistent Context
  • Reordered named-only arguments alphabetically
  • Updated all argument docs to be tables.
  • Fixed some bad docs.
  • New data type for switching and selecting browser, context and page. Now supports CURRENT == ACTIVE and ALL == ANY. Not longer case sensitive.

Backwards INCOMPATIBLE changes:

  • Changed arguments for the expected assertion argument from expected_value or expected_state to assertion_expected as on all other getters for the following keywords:
    • Get Checkbox State
    • Get Element Count
    • Get Table Cell Index
    • Get Table Row Index
  • Keyboard Input has now a timedelta as type for the delay argument. Before it was integer in milliseconds
  • Mouse Button has now a timedelta as type for the delay argument. Before it was integer in milliseconds

Bugfixes:

  • New Persistent Context could not use timeout argument set to 0
  • New Context viewport argument can now be ${None} to be able to open full screen browsers.

@Snooz82 Snooz82 mentioned this pull request Sep 18, 2022
Closed
@Snooz82 Snooz82 self-assigned this Sep 19, 2022
@Snooz82 Snooz82 added this to the v13.5.0 milestone Sep 19, 2022
@Snooz82 Snooz82 force-pushed the topic/argument_docs branch from 7833fac to 8dd8d2a Compare September 19, 2022 23:13
@Snooz82 Snooz82 marked this pull request as ready for review September 19, 2022 23:25
@Snooz82
changed signiture from expected_value to assertion_expected of:
1303dae 
- get_checkbox_state
- get_element_count
- get_table_cell_index
- get_table_row_index

Changed `keyboard_input` delay from ms to timedelta

Updated all docs.

Fixed some bugs in New Persistent Context

Added Type hint to Switch and Close Keywords
@Snooz82
fixed viewport None
19212b5 
Signed-off-by: René Rohner <snooz@posteo.de>
@Snooz82
fixed utest
67cf265 
Signed-off-by: René Rohner <snooz@posteo.de>
@Snooz82
deprecated positional arguments for __init__, New Context, New Browse…
ba2123c 
…r and New Persistent Context

Signed-off-by: René Rohner <snooz@posteo.de>
@Snooz82
fixed atest
7a489fe 
Signed-off-by: René Rohner <snooz@posteo.de>
@Snooz82
changed delay of Mouse Button to timedelta
15d7bcf 
Signed-off-by: René Rohner <snooz@posteo.de>
@Snooz82
removed browser.json which checked in by accident
d11a0ab 
Signed-off-by: René Rohner <snooz@posteo.de>
@Snooz82
fixed logs
ddeae22 
Signed-off-by: René Rohner <snooz@posteo.de>
@Snooz82
linted
cccf067 
Signed-off-by: René Rohner <snooz@posteo.de>
@Snooz82 Snooz82 force-pushed the topic/argument_docs branch from 8dd8d2a to cccf067 Compare September 20, 2022 06:34
@Snooz82
added error on int usage for Keyboard Input and Mouse Button delay
58f30cd 
Signed-off-by: René Rohner <snooz@posteo.de>
@Snooz82 Snooz82 merged commit ccf92c8 into main Sep 20, 2022
@Snooz82 Snooz82 deleted the topic/argument_docs branch September 20, 2022 07:19
This was referenced Sep 23, 2022
Closed
Closed
Closed
@Snooz82 Snooz82 added the enhancement New feature or request label Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkorpela mkorpela mkorpela approved these changes

Assignees

@Snooz82 Snooz82

Labels
deprecation enhancement New feature or request priority: critical
Projects
None yet
Milestone
v14.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Snooz82 @mkorpela