Added Scope feature to timeout, retry_assertion and strice_mode #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snooz82
commented
Sep 21, 2022
| if self._auto_closing_level == AutoClosingLevel.TEST: | ||
| try: | ||
| self._execution_stack.append(self.get_browser_catalog()) | ||
| except ConnectionError as e: | ||
| logger.debug(f"Browser._start_test connection problem: {e}") | ||
|
|
||
| def _start_keyword(self, name, attrs): |
There was a problem hiding this comment.
This code is just moved and unaltered from the lower part of that file, so that it is in a better place between start and end test
Snooz82
commented
Sep 21, 2022
| @@ -509,6 +509,7 @@ def get_selected_options( | |||
| option_attribute: SelectAttribute = SelectAttribute.label, | |||
| assertion_operator: Optional[AssertionOperator] = None, | |||
| *assertion_expected, | |||
There was a problem hiding this comment.
The message argument was just missing...
Snooz82
force-pushed
the
topic/WaitForCondition
branch
from
f95480b to
c522fa3
Compare
mkorpela
approved these changes
Sep 21, 2022
Snooz82
force-pushed
the
topic/WaitForCondition
branch
from
1a4c54d to
263a60b
Compare
Signed-off-by: René Rohner <snooz@posteo.de>
Signed-off-by: René Rohner <snooz@posteo.de>
Signed-off-by: René Rohner <snooz@posteo.de>
Signed-off-by: René Rohner <snooz@posteo.de>
Signed-off-by: René Rohner <snooz@posteo.de>
Signed-off-by: René Rohner <snooz@posteo.de>
Signed-off-by: René Rohner <snooz@posteo.de>
Signed-off-by: René Rohner <snooz@posteo.de>
Signed-off-by: René Rohner <snooz@posteo.de>
Snooz82
force-pushed
the
topic/WaitForCondition
branch
from
6acb9cb to
6adfed5
Compare
Signed-off-by: René Rohner <snooz@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this feature a scope is added to the following keywords:
Set Browser TimeoutSet Strict ModeSet Retry Assertions ForWith that scope argument one can set the "live time" of that setting.
Available Scopes are:
Global,SuiteandTest/TaskLive Times:
Globalscope will live forever until it is overwritten by anotherGlobalscope.Suitescope will locally override theGlobalscope and live until the end of the Suite within it is set, or if it is overwritten by a later setting withGlobalor same scope. Children suite does inherit the setting from the parent suite but also may have its own localSuitesetting that then will be inherited to its children suites.TestorTaskscope will be inherited from its parent suite but when set, lives until the end of that particular test or task.A new set higher order Scope will always remove the lower order scope which may be in charge.
So the setting of a
Suitescope from a test, will set that scope to the robot file suite where that test is and removes theTestscope that has been in place.Bugfixes: