Infer data type when variable is used as array index access (#440)

MarkusAmshove · Dec 1, 2023 · 59a49d2 · 59a49d2
2 parents c8b4137 + d803a9e
commit 59a49d2
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 0 deletions.
diff --git a/libs/natls/src/test/java/org/amshove/natls/quickfixes/UnresolvedReferenceQuickFixShould.java b/libs/natls/src/test/java/org/amshove/natls/quickfixes/UnresolvedReferenceQuickFixShould.java
@@ -642,4 +642,31 @@ void addAVariableToAGroupInAnImportedDataArea()
 			END-DEFINE
 			""");
 	}
+
+	@Test
+	void addAVariableWithInferredTypeWhenVariableIsUsedAsArrayAccess()
+	{
+		assertCodeActionWithTitle("Declare local variable #INDEX", "LIBONE", "MEINS.NSN", """
+			DEFINE DATA
+			LOCAL
+			1 #ARR (A10/1:*)
+			END-DEFINE
+
+			#ARR(#IN${}$DEX) := 'A'
+
+			END
+			""")
+			.fixes(ParserError.UNRESOLVED_REFERENCE.id())
+			.resultsApplied("""
+			DEFINE DATA
+			LOCAL
+			1 #INDEX (I4)
+			1 #ARR (A10/1:*)
+			END-DEFINE
+
+			#ARR(#INDEX) := 'A'
+
+			END
+				""");
+	}
 }
diff --git a/libs/natparse/src/main/java/org/amshove/natparse/parsing/TypeInference.java b/libs/natparse/src/main/java/org/amshove/natparse/parsing/TypeInference.java
@@ -104,6 +104,11 @@ public static Optional<IDataType> inferTypeForTokenInStatement(SyntaxToken token
 			return Optional.of(I4);
 		}
 
+		if (tokenNode.parent() instanceof IVariableReferenceNode) // Array access
+		{
+			return Optional.of(I4);
+		}
+
 		return Optional.empty();
 	}