NPP045 should be a Linter thing

[Claes65]

In my opinion :)

[Claes65]

Do you agree? @MarkusAmshove then I can do this and use this NPP045 for my new NPP050 instead.

[MarkusAmshove]

Yeah, I can move it into a linter rule

[Claes65]

I’ll do it. ☺️

[MarkusAmshove]

When you remove the rule/the check you should see the failing tests and make linter tests out of them :-)

[Claes65]

Not sure what you mean? Maybe you should do it after all? ;)

[MarkusAmshove]

The current tests for this rule are in a resources file and not in a Java file I think.
So to identify the testcases you can write for the analyzer you can remove the reporting of this issue (there is only one place) and see which tests break to look at the source to get an idea for testcases.

But I can also do it if you want :-)

[Claes65]

Maybe it’s better if you do it. But no rush. :)

[MarkusAmshove]

Is #394 ready to merge? I'll do the number adjustment after merging then, so the builds stay green :-)