Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System Functions brush-up #334

Merged
merged 14 commits into from
Aug 4, 2023

Conversation

Claes65
Copy link
Contributor

@Claes65 Claes65 commented Jul 19, 2023

No description provided.

@Claes65 Claes65 marked this pull request as ready for review July 19, 2023 14:43
@Claes65
Copy link
Contributor Author

Claes65 commented Jul 19, 2023

If you can show me how to do a type check, then I can add that as well before we close this. @MarkusAmshove

@Claes65 Claes65 marked this pull request as draft July 20, 2023 07:10
@Claes65 Claes65 marked this pull request as ready for review July 20, 2023 14:28
Claes65 added 3 commits July 25, 2023 11:09
checking null from type()
@Claes65
Copy link
Contributor Author

Claes65 commented Jul 25, 2023

pls check against your source code, @MarkusAmshove - I am happy from my side now.

Copy link
Owner

@MarkusAmshove MarkusAmshove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can simplify the code a bit by introducing a new interface for these type of functions. If some functions take multiple parameter, we might have to add different interfaces.

Also I get around 28k new diagnostics, but those are all around copy codes. I'll try to see if I find a quick solution so that we don't need to have #125 in place before we merge this

@Claes65
Copy link
Contributor Author

Claes65 commented Jul 26, 2023

We can simplify the code a bit by introducing a new interface for these type of functions. If some functions take multiple parameter, we might have to add different interfaces.

Also I get around 28k new diagnostics, but those are all around copy codes. I'll try to see if I find a quick solution so that we don't need to have #125 in place before we merge this

Excellent! Thanks for this. I’ll do the changes tomorrow as I’m ooo today. I hope you find a solution to cc - curious to what the issue is.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.3% 97.3% Coverage
0.0% 0.0% Duplication

@MarkusAmshove MarkusAmshove added the natparse🔎 Parser and project structure label Aug 4, 2023
@MarkusAmshove MarkusAmshove added this to the v0.8 milestone Aug 4, 2023
@MarkusAmshove
Copy link
Owner

I get 11 new diagnostics, but they'll be gone when type information are loaded for DDM fields

@MarkusAmshove MarkusAmshove merged commit 144244c into MarkusAmshove:main Aug 4, 2023
@Claes65 Claes65 deleted the systemfunctions-brushup branch October 2, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
natparse🔎 Parser and project structure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants