-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System Functions brush-up #334
System Functions brush-up #334
Conversation
If you can show me how to do a type check, then I can add that as well before we close this. @MarkusAmshove |
added CC check
added NONE
checking null from type()
pls check against your source code, @MarkusAmshove - I am happy from my side now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can simplify the code a bit by introducing a new interface for these type of functions. If some functions take multiple parameter, we might have to add different interfaces.
Also I get around 28k new diagnostics, but those are all around copy codes. I'll try to see if I find a quick solution so that we don't need to have #125 in place before we merge this
libs/natparse/src/main/java/org/amshove/natparse/natural/IAtnOperandNode.java
Outdated
Show resolved
Hide resolved
libs/natparse/src/main/java/org/amshove/natparse/parsing/TypeChecker.java
Outdated
Show resolved
Hide resolved
libs/natparse/src/main/java/org/amshove/natparse/parsing/TypeChecker.java
Outdated
Show resolved
Hide resolved
Excellent! Thanks for this. I’ll do the changes tomorrow as I’m ooo today. I hope you find a solution to cc - curious to what the issue is. |
Kudos, SonarCloud Quality Gate passed! |
I get 11 new diagnostics, but they'll be gone when type information are loaded for DDM fields |
No description provided.