Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type checking of binary type #335

Merged
merged 10 commits into from
Aug 4, 2023

Conversation

Claes65
Copy link
Contributor

@Claes65 Claes65 commented Jul 21, 2023

No description provided.

@Claes65
Copy link
Contributor Author

Claes65 commented Jul 21, 2023

Gotta add all 121 (11*11) possible combinations from this document: https://documentation.softwareag.com/natural/nat912mf/pg/pg_furth_arithm.htm and also add some tests for literals and SF/SVs as well. Some combinations does not work still. But you can look at the new methods in IDataType @MarkusAmshove
Tests does fail as well, the family stuff is not up-to-speed yet, but will be next week. 💯

@Claes65 Claes65 marked this pull request as ready for review July 24, 2023 13:39
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.8% 96.8% Coverage
0.0% 0.0% Duplication

@MarkusAmshove MarkusAmshove changed the title binary Compatibility Fix type checking of binary type Aug 4, 2023
@MarkusAmshove MarkusAmshove added the bug🪲 Something isn't working label Aug 4, 2023
@MarkusAmshove MarkusAmshove added this to the v0.8 milestone Aug 4, 2023
@MarkusAmshove MarkusAmshove merged commit 671fdce into MarkusAmshove:main Aug 4, 2023
@Claes65 Claes65 deleted the bugfix-type-compatibility branch August 4, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants