Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load variable type info from DDMs #352

Merged
merged 16 commits into from
Aug 15, 2023

Conversation

MarkusAmshove
Copy link
Owner

@MarkusAmshove MarkusAmshove commented Aug 11, 2023

closes #15
closes #190
closes #338

  • If the data type length in the view is different than the one in the DDM, report a diagnostic. Do this only if data format is the same.
  • Look how many diagnostics arise when the whole data type differs
  • If the DDM is not resolvable, report a diagnostic
  • If the DDM field is not resolvable from the view variable, report a diagnostic
  • Add array bounds for multiple value fields
  • Add array bounds for periodic groups
  • Allow C*FIELD variables with type (I4 probably?)
  • Check on C*FIELD if FIELD exists on DDM
  • Allow redefinition of superdescriptors
  • Allow REDEFINE of the view/Remove exclusion from REDEFINE from views in DataDefinitionParser::checkRedefineLength()
  • Look for isInView() usages and see if they now can be solved
  • Handle variables that only have dimensions explicitly specified, not the data type

@MarkusAmshove MarkusAmshove added the natparse🔎 Parser and project structure label Aug 11, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

89.0% 89.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@MarkusAmshove MarkusAmshove added this to the v0.9 milestone Aug 15, 2023
@MarkusAmshove MarkusAmshove merged commit 916a8ba into main Aug 15, 2023
@MarkusAmshove MarkusAmshove deleted the natparse/load-variable-types-from-ddm branch August 15, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
natparse🔎 Parser and project structure
Projects
None yet
1 participant