Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optional IN LOGICAL order for READ #370

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix optional IN LOGICAL order for READ #370

merged 1 commit into from
Sep 18, 2023

Conversation

Claes65
Copy link
Contributor

@Claes65 Claes65 commented Sep 18, 2023

No description provided.

@Claes65 Claes65 changed the title "IN" was not catered for correctly "IN" was not catered for correctly in READ LOGICAL Sep 18, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Claes65 Claes65 marked this pull request as ready for review September 18, 2023 10:45
@Claes65 Claes65 changed the title "IN" was not catered for correctly in READ LOGICAL Bugfix: READ ... IN LOGICAL Sep 18, 2023
@MarkusAmshove MarkusAmshove added the natparse🔎 Parser and project structure label Sep 18, 2023
@MarkusAmshove MarkusAmshove added this to the v0.10 milestone Sep 18, 2023
@MarkusAmshove
Copy link
Owner

Seems fine to me, not adding/deleting any diagnostics on our side. If you're ready I can merge :)

@MarkusAmshove MarkusAmshove added the bug🪲 Something isn't working label Sep 18, 2023
@MarkusAmshove MarkusAmshove changed the title Bugfix: READ ... IN LOGICAL Fix optional IN LOGICAL order for READ Sep 18, 2023
@Claes65
Copy link
Contributor Author

Claes65 commented Sep 18, 2023

This one is fine to merge.

@MarkusAmshove MarkusAmshove merged commit 82be2d0 into MarkusAmshove:main Sep 18, 2023
@Claes65 Claes65 deleted the natparse/bugfix-for-read-logical branch October 2, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug🪲 Something isn't working natparse🔎 Parser and project structure
Projects
None yet
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.
2 participants
@Claes65 @MarkusAmshove