Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement experimental async initialization #409

Merged
merged 5 commits into from
Oct 28, 2023

Conversation

MarkusAmshove
Copy link
Owner

No description provided.

@MarkusAmshove MarkusAmshove added the natls💻 Language Server implementation label Oct 28, 2023
@MarkusAmshove MarkusAmshove added this to the v0.10 milestone Oct 28, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

85.0% 85.0% Coverage
0.0% 0.0% Duplication

@MarkusAmshove MarkusAmshove merged commit 0fabaaf into main Oct 28, 2023
8 checks passed
@MarkusAmshove MarkusAmshove deleted the natls/background-tasks branch October 28, 2023 16:33
@Claes65
Copy link
Contributor

Claes65 commented Oct 30, 2023

@MarkusAmshove
.peek(f -> monitor.progress("Parsing data areas %s".formatted(f.getReferableName()))) ->
.peek(f -> monitor.progress("Parsing data areas %s".formatted(f.getReferableName()),0))
in NaturalLanguageService.java line 439. Otherwise it's not responding.

@MarkusAmshove
Copy link
Owner Author

MarkusAmshove commented Oct 30, 2023

@Claes65 when not passing a percentage it increases it automatically: https://github.com/MarkusAmshove/natls/pull/409/files#diff-b9da325b6c2b2cd99f4d5fdc3e89b8a65b46d0cd8309d21a23c204b5b30d3c5aR21

it might not pass the threshold for the message based percentage on that step though, but I don't see that as a problem.
Unless I'm missing something :)

@Claes65
Copy link
Contributor

Claes65 commented Oct 30, 2023

@Claes65 when not passing a percentage it increases it automatically: https://github.com/MarkusAmshove/natls/pull/409/files#diff-b9da325b6c2b2cd99f4d5fdc3e89b8a65b46d0cd8309d21a23c204b5b30d3c5aR21

it might not pass the threshold for the message based percentage on that step though, but I don't see that as a problem. Unless I'm missing something :)

Not sure - but it hung up Eclipse when 0 was not mentioned. I guess too many messages is sent without the 0 (as 0 means nothing is sent it seems).

@MarkusAmshove
Copy link
Owner Author

I'll change it to either not exceeding 100% or not increasing it at all for message based stuff

@MarkusAmshove
Copy link
Owner Author

@Claes65 should be resolved in current main branch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
natls💻 Language Server implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants