Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse DDM subdescriptors #508

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Parse DDM subdescriptors #508

merged 3 commits into from
Dec 30, 2024

Conversation

MarkusAmshove
Copy link
Owner

Source fields from subdescriptors will now be added as descriptors with type SUBDESCRIPTOR.

Source fields from subdescriptors will now be added as descriptors with type `SUBDESCRIPTOR`.
@MarkusAmshove MarkusAmshove added the natparse🔎 Parser and project structure label Sep 3, 2024
@MarkusAmshove MarkusAmshove added this to the v0.15 milestone Sep 3, 2024
@MarkusAmshove
Copy link
Owner Author

@awilkins do you happen to know if predict generates something different when the field itself is a descriptor?

Having this case:

  1 AG A-SUBDESCRIPTOR                   A   25  N S
*      -------- SOURCE FIELD(S) -------
*      SUB-ONE (1-15)
*      SUB-TWO (15-25)
*      SUB-THREE (1-1)

How do I know if A-SUBDESCRIPTOR is a descriptor itself?
The documentation says "A subdescriptor is a descriptor derived from a portion of an elementary field. The elementary field may or may not be a descriptor itself."
So there must be a distinction :)
Do you happen to know if such a field in one of your DDMs is also a descriptor? And maybe have one that is not a descriptor, so we can see if we can distinguish them?

Copy link

sonarqubecloud bot commented Sep 3, 2024

@MarkusAmshove MarkusAmshove linked an issue Sep 3, 2024 that may be closed by this pull request
@MarkusAmshove MarkusAmshove merged commit 9de0369 into main Dec 30, 2024
9 checks passed
@MarkusAmshove MarkusAmshove deleted the natparse/ddm-subdescriptors branch December 30, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
natparse🔎 Parser and project structure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DDM : subdescriptor
1 participant