Opening a remote browser with custom web driver timeouts #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default way of creating a web driver has a hard-coded timeout for 3 hours on socket timeout. We are using browser spinned up in docker containers, and no matter if we wait on port to be opened, sometimes it is too early to connect. That ends up in waiting for 3 hours.
This modification adds an overload with two extra arguments for Open Browser keyword, and you can specify both connection and socket timeouts. It has effect only for remote browsers of course.
The implementation mimics the original behaviour of default driver creation, and the code plays with internal classes of selenium is isolated.
A TimeUtils with JUnit tests also added for convention, so the Open Browser keyword understands Robot Time String format and converts them to milliseconds for the API.
Kudos to @JoepWeijers for the patch idea.