-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 added new theme "Chimera-autumn" #78
Conversation
Signed-off-by: Sindre Kjelsrud <kjelsrudsindre@gmail.com>
Signed-off-by: Sindre Kjelsrud <kjelsrudsindre@gmail.com>
If you could provide a screenshot that would be nice. I suggest you to copy The html of https://www.cssbed.com/sakura-vader/ as it showcases a wide variety of html-elements |
Here are two screenshots for the theme. Btw I think you should reference to either the HTML of the link you provided or an example file you have coded yourself in the GUIDE, so contributors know what is preferred. |
Theme looks great! However it looks like there is an issue on The input type button under The radiobuttons: it dosent look like The text is visible 🫣 Also could you try white button text just to see wether it looks better? On the previous note of using cssbed as example html code, that is just my personal preference for testing but we could recommend it in The guide :)😎 |
I think that it is important to document The available themes in the readme, which is why i will suggest that you do appropriate changes there as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Feel free to merge after my comments is addressed 🤘
Signed-off-by: Sindre Kjelsrud <kjelsrudsindre@gmail.com>
Signed-off-by: Sindre Kjelsrud <kjelsrudsindre@gmail.com>
Looking good |
I have not updated the README with new theme as I was unsure if this is something that needed to be done.
Chimera probably has 3 main themes and the rest are extras??
If I contribute more themes, do you want a screenshot of the theme in the PR for easier checkout or not?