Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 added new theme "Chimera-autumn" #78

Merged
merged 4 commits into from
Jan 11, 2024
Merged

💄 added new theme "Chimera-autumn" #78

merged 4 commits into from
Jan 11, 2024

Conversation

SindreKjelsrud
Copy link
Collaborator

I have not updated the README with new theme as I was unsure if this is something that needed to be done.
Chimera probably has 3 main themes and the rest are extras??

If I contribute more themes, do you want a screenshot of the theme in the PR for easier checkout or not?

Signed-off-by: Sindre Kjelsrud <kjelsrudsindre@gmail.com>
Signed-off-by: Sindre Kjelsrud <kjelsrudsindre@gmail.com>
@MarkusJohansen
Copy link
Owner

If you could provide a screenshot that would be nice. I suggest you to copy The html of https://www.cssbed.com/sakura-vader/ as it showcases a wide variety of html-elements

@SindreKjelsrud
Copy link
Collaborator Author

SindreKjelsrud commented Jan 10, 2024

Here are two screenshots for the theme.

Btw I think you should reference to either the HTML of the link you provided or an example file you have coded yourself in the GUIDE, so contributors know what is preferred.

Screenshot from 2024-01-10 22-09-46
Screenshot from 2024-01-10 22-10-22

@MarkusJohansen
Copy link
Owner

Theme looks great! However it looks like there is an issue on The input type button under The radiobuttons: it dosent look like The text is visible 🫣

Also could you try white button text just to see wether it looks better?

On the previous note of using cssbed as example html code, that is just my personal preference for testing but we could recommend it in The guide :)😎

@MarkusJohansen
Copy link
Owner

I think that it is important to document The available themes in the readme, which is why i will suggest that you do appropriate changes there as well.

Copy link
Owner

@MarkusJohansen MarkusJohansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Feel free to merge after my comments is addressed 🤘

Signed-off-by: Sindre Kjelsrud <kjelsrudsindre@gmail.com>
Signed-off-by: Sindre Kjelsrud <kjelsrudsindre@gmail.com>
@SindreKjelsrud
Copy link
Collaborator Author

README updated w/ screenshot of theme. Regarding the text under radiobuttons, it was just a screenshot error so it's there. Also here's the white button text:

Screenshot from 2024-01-11 11-00-01

@SindreKjelsrud SindreKjelsrud merged commit efcc011 into main Jan 11, 2024
1 check passed
@SindreKjelsrud SindreKjelsrud deleted the theme/autumn branch January 11, 2024 10:15
@MarkusJohansen
Copy link
Owner

Looking good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants