💄 add new theme "Chimera-nightsky" #83
Conversation
Signed-off-by: Sindre Kjelsrud <kjelsrudsindre@gmail.com>
Signed-off-by: Sindre Kjelsrud <kjelsrudsindre@gmail.com>
|
Screenshot of Chimera-nightsky:
|
Signed-off-by: Sindre Kjelsrud <kjelsrudsindre@gmail.com>
SindreKjelsrud
force-pushed
the
theme/nightsky
branch
from
48b3302 to
6a20724
Compare
There was a problem hiding this comment.
The theme looks nice and also very professional! However the link colors creates to little contrast between the background and the links, and this has to be adressed to make the theme accesible. I also think that the focus color doesnt quite fit the palette, which is why I would tweak this too. Experiment with different colors and find something that feels right 👍🏼 I added some suggestions, but feel free to try something else 💯
$Chimera-link: hsl(210, 90%, 60%);
$Chimera-focus: hsl(175, 70%, 50%);
|
We wont need the image in the readme as those have been purged to keep the package smaller. |
Signed-off-by: Sindre Kjelsrud <kjelsrudsindre@gmail.com>
Signed-off-by: Sindre Kjelsrud <kjelsrudsindre@gmail.com>
suggestion by @MarkusJohansen Signed-off-by: Sindre Kjelsrud <kjelsrudsindre@gmail.com>
|
Have you tried accesibility testing using google lighthouse? If thats the case, how did the accesibility score look? It should be pretty good to avoid contributing to making this issue even bigger: #104 |
Signed-off-by: Sindre Kjelsrud <kjelsrudsindre@gmail.com>
|
After updating some colors, the theme went from a 95 score to a 100 score in accessibility using google lighthouse locally.
|
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
SindreKjelsrud
dismissed
MarkusJohansen’s stale review
Requested changes have been addressed.
No description provided.