Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various config fixes #1012

Merged

Conversation

thisiskeithb
Copy link
Member

@thisiskeithb thisiskeithb commented Jan 28, 2024

Description

Various config fixes after running the build_all_examples script.

Changes should be obvious, but I dropped PREHEAT_2_LABEL / ABS items on a few configs since they were too low for ABS after making the max temp sanity check happy.

Remaining configs with build errors:

Configs with pending upstream (Marlin) support:

  • Creality/CR-6 SE/
  • Creality/Ender-5 S1/

Configs with non-standard warnings (not fixed here):

  • Creality/CR-10 Max/comparison between signed and unsigned integer expressions
  • Creality/CR-10S Pro/comparison between signed and unsigned integer expressions
  • Creality/CR-20/RepRapWorld Minitronics20/"LITTLE_ENDIAN" redefined / deleting object of polymorphic class type 'DoubleBufferedEPOutHandler' which has non-virtual destructor might cause undefined behavior
  • Creality/CR-30 PrintMill/unused variable 'z_raised'
  • Creality/Ender-5 Plus/CrealityV1 (RELOADED UI)/comparison between signed and unsigned integer expressions
  • MakerParts/Various framework-arduino-sam warnings
  • Malyan/M200/No CMSIS startup file defined, custom one should be used
  • Micromake/C1/basic/buffer' defined but not used / 'timepos' defined but not used
  • Micromake/C1/enhanced/buffer' defined but not used / 'timepos' defined but not used
  • Printrbot/PrintrboardG2/Various framework-arduino-sam warnings
  • UltiMachine/Archim1/Various framework-arduino-sam warnings
  • delta/FLSUN/Q5-nano_v2/Various mks_ui "not handled in switch" warnings
  • delta/Malyan M300/No CMSIS startup file defined, custom one should be used
  • delta/Dreammaker/Overlord/default argument given for parameter 2 of 'void PCA9632_buzz(long int, uint16_t)
  • delta/Dreammaker/Overlord_Pro/default argument given for parameter 2 of 'void PCA9632_buzz(long int, uint16_t)
  • Kingroon/KP5L-DIY/Various mks_ui "not handled in switch" warnings

Benefits

Configs will build correctly.

Upstream Marlin PRs with Fixes

@thisiskeithb thisiskeithb marked this pull request as draft January 28, 2024 07:05
@thisiskeithb thisiskeithb changed the title [WIP] Various config fixes Various config fixes Jan 28, 2024
@thisiskeithb thisiskeithb marked this pull request as ready for review January 28, 2024 21:24
@thisiskeithb thisiskeithb force-pushed the pr/config_fixes branch 3 times, most recently from 8844f51 to dfb425b Compare January 29, 2024 03:32
@thinkyhead
Copy link
Member

Good catch on the bad Sapphire Plus V2 endstop pin. Apparently that got broken by c31ece2.

@thinkyhead thinkyhead merged commit 66a95ec into MarlinFirmware:import-2.1.x Feb 2, 2024
1 check passed
@thisiskeithb thisiskeithb deleted the pr/config_fixes branch February 2, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants