🔥 Remove DISKIO_HOST_DRIVE #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI will fail due to a handful of Geeetech configs that still won't build correctly due to some LCD/library incompatibilities after MarlinFirmware/Marlin@ec7ab5a. |
thinkyhead
force-pushed
the
import-2.1.x
branch
2 times, most recently
from
c5e57b7
to
7eb7090
Compare
thisiskeithb
force-pushed
the
pr/remove_DISKIO_HOST_DRIVE
branch
from
b40ca83
to
f249c59
Compare
|
...PR fixed after recent force-pushes to |
thisiskeithb
force-pushed
the
pr/remove_DISKIO_HOST_DRIVE
branch
from
f249c59
to
2b9b45b
Compare
|
Rebased on current |
... and apparently some other recent changes: HEAD is now at f5cf667c95 🎨 Clarify some string parameters (#26949)
Building Configurations in config/examples/CNC/miniRambo ...
Building environment rambo for board MINIRAMBO (1201)...
In file included from Marlin/src/gcode/feature/digipot/../../../inc/MarlinConfigPre.h:37:0,
from Marlin/src/gcode/feature/digipot/../../../inc/MarlinConfig.h:28,
from Marlin/src/gcode/feature/digipot/M907-M910.cpp:23:
Marlin/src/gcode/feature/digipot/M907-M910.cpp: In static member function 'static void GcodeSuite::M907_report(bool)':
Marlin/src/gcode/feature/digipot/M907-M910.cpp:137:13: error: 'SP_E_STR' was not declared in this scope
, SP_E_STR, stepper.motor_current_setting[2] // E
^Edit: This CNC config was committed directly so it was not checked by CI: e7254f1 |
thinkyhead
force-pushed
the
pr/remove_DISKIO_HOST_DRIVE
branch
from
02c1b49
to
74dd24b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since MarlinFirmware/Marlin#19939 was closed & never merged, remove
DISKIO_HOST_DRIVEoption.Benefits
Removes dead config option
Related Issues