🎨 Use standard STRING_CONFIG_H_AUTHOR format #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap string in parenthesis per default & most configs.
thisiskeithb
force-pushed
the
pr/use_std_STRING_CONFIG_H_AUTHOR_format
branch
from
28ee158 to
d76b3aa
Compare
|
@thinkyhead If I wanted my name in the config I would have added it. I have removed them. |
rngkll
pushed a commit
to rngkll/Configurations
that referenced
this pull request
Oct 24, 2024
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com> Co-authored-by: ellensp <530024+ellensp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wrap
STRING_CONFIG_H_AUTHORstring in parenthesis per default & most configs.Benefits
Configs will match the standard
STRING_CONFIG_H_AUTHORformat.Note
Several configs will not build & will cause CI to fail, but they are a known issue. See #1068 for more details.