Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a few config errors #548

Merged
merged 4 commits into from
Aug 2, 2021
Merged

fix a few config errors #548

merged 4 commits into from
Aug 2, 2021

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented Aug 1, 2021

Description

I built all example configs under bugfix, found a few errors

  1. Testing Eryone/Thinker SE/:
    #error "BLTOUCH requires Z_MIN_ENDSTOP_INVERTING set to false. Please update your Configuration.h file."
    I set Z_MIN_ENDSTOP_INVERTING false

  2. Testing gCreate/gMax1.5+/:
    #error "BLTOUCH without BLTOUCH_SET_5V_MODE requires ENDSTOPPULLUPS, ENDSTOPPULLUP_ZMIN or ENDSTOPPULLUP_ZMIN_PROBE."
    Enabled ENDSTOPPULLUP_ZMIN

  3. Testing Mks/Robin_Lite3/:
    #error "SERIAL_PORT is set to -1, but the MOTHERBOARD has no native USB support. Set SERIAL_PORT to a valid value for your board."
    Error is correct, Updated Serial ports in Config.

  4. Testing Geeetech/A10M/Stock LCD/:
    Missing Configuration_adv.h (shared)
    Created an individual Configuration_adv.h

  5. Testing Geeetech/A10M/YHCB2004_V4.1/:
    Missing Configuration_adv.h (shared)
    Created an individual Configuration_adv.h

  6. Testing Geeetech/A10T/Stock LCD/:
    Missing Configuration_adv.h (shared)
    Created an individual Configuration_adv.h

  7. Testing Geeetech/A10T/YHCB2004_V4.1/:
    Missing Configuration_adv.h (shared)
    Created an individual Configuration_adv.h

Benefits

Users don't get these errors

@thinkyhead
Copy link
Member

When a Configuration_adv.h file is unmodified from the default, it can be left out so that there are fewer files to maintain.

@thinkyhead thinkyhead merged commit 95a6380 into MarlinFirmware:import-2.0.x Aug 2, 2021
@ellensp ellensp deleted the compile-issues branch August 2, 2021 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants