-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Teensy35_36_SIMPLE on LulzBot Mini2_Hibiscus and Mini2_Hibiscus_Experimental #752
Conversation
…xperimental See Configuration.h for details.
Did you start with a fresh / default config from the Configurations/config/default/Configuration.h Lines 23 to 24 in c27da0b
Also, Configs are also sorted by OEM -> Model, so these should be moved under This also needs MarlinFirmware/Marlin#24318 to be merged first. |
Yes, it's from a fresh pull, but the config isn't, I'll fix it |
This config also directly fits into 2.1-bugfix |
Bugfix strips out those errors automatically. They need to be there in the import branches. Please fix it. |
:-) Didn't know that. Nice! and Done! |
config/examples/Teensy/35_36_SIMPLE/Mini2_Hibiscus_Experimental/Configuration.h
Outdated
Show resolved
Hide resolved
It is important that you start with a fresh/clean copy of Configurations/config/default/Configuration.h Lines 2733 to 2736 in c27da0b
and Configurations/config/default/Configuration.h Lines 2763 to 2767 in c27da0b
You're also missing these from Configurations/config/default/Configuration_adv.h Lines 1665 to 1672 in c27da0b
and Configurations/config/default/Configuration_adv.h Lines 3891 to 3897 in c27da0b
and Configurations/config/default/Configuration_adv.h Lines 4442 to 4443 in c27da0b
|
I'll have to hand patch those manually, not a big deal. I'll push those changes shortly. Thanks for finding these. |
The import-2.1.x configs are different to bugfix-2.1.x |
Right, Not a big deal, they're patched, updating them... |
Let me know if I missed/messed up anything else, but the UUID is required, which is why it's in a deeply nested directory specifically naming the machine. |
@cp2004 That is correct and intentional. Through the magic of scripting/deployment, pending features & “Do not build with…” lines are removed when changes are deployed to bugfix. |
This still needs to be moved to the main Lulzbot folder. |
Is there one? Problem is that it's no longer really a lulzbot machine... it's Teensy based now, just uses the lulzbot frame, and none of the electronics except for the wiring harness, and steppers/sensors. |
Oh yeah, and worse, it was a prototype, never released! Notice that I disabled any use of the display too, so a regular user is going to be very confused as to why it no longer displays anything... the driver for the display must be heavily patched, because of the software spi implementation trying to move data at 30MHz on this particular board... and I'm not going to be using that anyway. |
See the Ender-3 config folder (or any other Creality config) where it has the most configs/upgrades: https://github.com/MarlinFirmware/Configurations/tree/import-2.1.x/config/examples/Creality/Ender-3 The standard patten is OEM -> Model -> Boards/Upgrades It would also help to add a |
So should this config really be added then or is this just a one-off for your personal use? |
Good idea, I'll add the readme, I'm sure others out there who want to upgrade easily DIY. So... the TLDR is: |
I never said it was. I am saying that you need to move your config to the Lulzbot folder. |
That's fine, but won't it cause confusion? Are there any other taz-4's that have the guts torn out and replaced? |
Hopefully this won't cause any confusion, I'll put a README.md for Teensy (and name it Teensy boards) so that people can at least locate an example for the board if you think that would be a good idea. |
@xxxajk — This one still doesn't build because there's no |
See Configuration.h for details.
Requirements
As listed in Configuration.h:
Description
See above.
Benefits
Allows replacement of AVR with something better.
Related Issues
None.