Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use DWIN_MARLINUI_PORTRAIT on ender3 v2 marlin user interface. #968

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented Aug 26, 2023

Ender 3 V2 screens are by default in portrait mode not landscape. So the Marlin UI default should be portrait

Requirements

Ender 3 v2 display with encoder running marlin ui

Description

Ender 3 V2 screens are by default in portrait mode not landscape. So the Marlin UI default should be in portrait

Benefits

Less confused users

Related Issues

MarlinFirmware/Marlin#26205

Ender 3 V2 screens are in portrait mode not landscape.
@ellensp
Copy link
Contributor Author

ellensp commented Aug 26, 2023

Test fails on: "#error "CAUTION! Ender-3 V2 display requires a custom cable with TX = P0_15, RX = P0_16. See 'pins_BTT_SKR_E3_TURBO.h' for details. (Define NO_CONTROLLER_CUSTOM_WIRING_WARNING to suppress this warning.)""

Which is deliberate. We want this to error when a user tries this config

@thinkyhead thinkyhead merged commit 8cc08cb into MarlinFirmware:import-2.1.x Oct 5, 2023
@ellensp ellensp deleted the patch-1 branch October 6, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants