Skip to content

Commit

Permalink
🎨 Lowercase followup
Browse files Browse the repository at this point in the history 
Followup to #25939
  • Loading branch information
@thinkyhead
thinkyhead committed Jun 15, 2023
1 parent 5cfe3af commit 166ed28
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Marlin/src/MarlinCore.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1583,7 +1583,7 @@ void setup() {
#endif

#if HAS_DWIN_E3V2_BASIC
SETUP_RUN(DWIN_InitScreen());
SETUP_RUN(dwinInitScreen());
#endif

#if HAS_SERVICE_INTERVALS && !HAS_DWIN_E3V2_BASIC
Expand Down

3 comments on commit 166ed28

@RV-from-be
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thinkyhead You can add another followup! You forgot 2 folders from your branch to merge, folder proui and common!

@classicrocker883
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the thing is proui has a whole bunch that would have to get renamed like this, also in the dwin.cpp file. unfortunately it may not be compatible with Mriscoc's actual repo because libproui (the ProUI library) has references to these. I mean sure it can be fine with Marlin, but may not merge correctly if you wanted all the ProUI features and stuff.

@RV-from-be
Copy link

@RV-from-be RV-from-be commented on 166ed28 Jun 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thinkyhead @classicrocker883 I was just making this remark for those who want to update their version Marlin bugifx with the last commits and marlinui or jyersui or crealityui. These UI use common folder. If you try to compile one of these interfaces, compilation failed! Actually files in common folder aren't updated with lowercase method !
common folder updated with lowercase method -> common.zip

If you (@thinkyhead) say you have to wait then you also had to wait before merging marlinui or jyersui or crealityui with lowercase method ;-).

Please sign in to comment.