Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] no text display for change filament #17696

Closed
88mich opened this issue Apr 24, 2020 · 8 comments
Closed

[BUG] no text display for change filament #17696

88mich opened this issue Apr 24, 2020 · 8 comments

Comments

@88mich
Copy link

88mich commented Apr 24, 2020

Bug Description

no item is displayed in the lcd menu under the item change filament.
when the English language is selected I can choose the extruder to change the filament but if I select the Italian language nothing appears in the menu

Steps to Reproduce

My printer is a A10M so i think the problem is in the italian's multi extruder menu

  1. set multiextruder print such as A10M
  2. change language to italian
  3. go in the print menu > cambia filamento>

I think the problem is because in Italian there are too many characters for that line

@GMagician
Copy link
Contributor

I can't check now (printer is busy) but if messages are too long you may try to shrink them and test.
filamento may be written as filam..
All messages are within 20 char, but in some menù are required max 17 chars.
Usually I translate all messages but sometimes I don't have options installed or I misunderstand their meaning and translation is not perfect.
If you find some "bad" translation or other "too long" messages and you're not able to post a PR, let me know

@88mich
Copy link
Author

88mich commented Apr 25, 2020

IMG_20200425_165746

I confirm, there are too much character for thoose Lines. I change "filamento" with "filo" and everything works fine

@GMagician
Copy link
Contributor

That's good will you post a PR for it or should I manage it for you?

@GMagician
Copy link
Contributor

it's better 'filam.' or 'filo'? Correct translation should be the first in my opinion

@GMagician
Copy link
Contributor

Probably also MSG_FILAMENTUNLOAD_E should be shrinked to Rimuovi filam. * or Rimuovi filo *

If 'filo' is used I think all 'filamento' references should be changed too, to be consistent

@88mich
Copy link
Author

88mich commented Apr 25, 2020 via email

@GMagician
Copy link
Contributor

@88mich you may close this now...fix has been merged

@88mich 88mich closed this as completed Apr 25, 2020
@lock
Copy link

lock bot commented Jun 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants