Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTO_BED_LEVELING_3POINT manual probe positions ignored #17870

Closed
nick9one1 opened this issue May 4, 2020 · 3 comments
Closed

AUTO_BED_LEVELING_3POINT manual probe positions ignored #17870

nick9one1 opened this issue May 4, 2020 · 3 comments

Comments

@nick9one1
Copy link

nick9one1 commented May 4, 2020

Marlin.zip

Bug Description

When using AUTO_BED_LEVELING_3POINT and setting the XY in

/**
 * Points to probe for all 3-point Leveling procedures.
 * Override if the automatically selected points are inadequate.
 */

manual probe positions are ignored.

the standard 3 point probe positions cause the furthest Y coordinate to probe off the back of my bed.

G1 X15 Y125 is as far back as I can go.

when the manaual probe position is set to

/**
 * Points to probe for all 3-point Leveling procedures.
 * Override if the automatically selected points are inadequate.
 */
#if EITHER(AUTO_BED_LEVELING_3POINT, AUTO_BED_LEVELING_UBL)
  //#define PROBE_PT_1_X 15
  #define PROBE_PT_1_Y 125
  //#define PROBE_PT_2_X 15
  //#define PROBE_PT_2_Y 20
  //#define PROBE_PT_3_X 170
  //#define PROBE_PT_3_Y 20
  #endif

G29 ignores #define PROBE_PT_1_Y 125 and still probes at Y180

Marlin.zip

@SwiftingSpeed
Copy link

The conditional check needs all three points to be defined fully (both X and Y), you can't define part of them.
https://github.com/MarlinFirmware/Marlin/blob/36bab2b30e11817377bde66650a1404d574b16a4/Marlin/src/inc/Conditionals_post.h#L1995

thinkyhead added a commit that referenced this issue May 10, 2020
@thinkyhead
Copy link
Member

Now patched with a better sanity check.

vgadreau pushed a commit to vgadreau/Marlin that referenced this issue May 29, 2020
@github-actions
Copy link

github-actions bot commented Jul 9, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2020
jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this issue Aug 7, 2020
njibhu pushed a commit to njibhu/Marlin that referenced this issue Aug 24, 2020
HairingX pushed a commit to HairingX/Marlin that referenced this issue Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants