Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER not working #1830

Closed
lcfm1 opened this issue Apr 6, 2015 · 14 comments
Closed

#define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER not working #1830

lcfm1 opened this issue Apr 6, 2015 · 14 comments

Comments

@lcfm1
Copy link
Contributor

lcfm1 commented Apr 6, 2015

screen is not earned until I added the following parameters:

define DOGLCD

define SDSUPPORT

define U8GLIB_ST7920

@AnHardt
Copy link
Member

AnHardt commented Apr 6, 2015

@lcfm1
Can it be, that for some reason, you use an old 'Configuration_adv.h'?
Than 'Conditionals.h' would not be included.

May also help against #1832.

@lcfm1
Copy link
Contributor Author

lcfm1 commented Apr 6, 2015

No, I took the last archive, taking the delta printer settings from examples in the subfolder and got this error

@alexborro
Copy link
Contributor

That may be the problem.. The DAMN specific files.

We should just include some specific file after the configuration.h and
configuration_adv.h to redefine a few specific labels.

Cheers

Alex
Em 06/04/2015 07:24, "lcfm1" notifications@github.com escreveu:

No, I took the last archive, taking the delta printer settings from
examples in the subfolder and got this error


Reply to this email directly or view it on GitHub
#1830 (comment)
.

@lcfm1
Copy link
Contributor Author

lcfm1 commented Apr 6, 2015

http://pastebin.com/jfGBa8fA my conf.

@AnHardt
Copy link
Member

AnHardt commented Apr 6, 2015

Would you please test to insert

#error "Test error"

in line 46 of 'Conditionals.h'.

If you can still compile without errors, please insert the same line into

line 5 of 'Configuration_adv.h' right after #include "Conditionals.h"

Than please report back.

@lcfm1
Copy link
Contributor Author

lcfm1 commented Apr 6, 2015

AnHardt, got error: Conditionals.h:46:6: error: #error "Test error"

@AnHardt
Copy link
Member

AnHardt commented Apr 6, 2015

Ok.
Please remove the error line.
Please undefine
#define DOGLCD
#define SDSUPPORT
#define U8GLIB_ST7920
in 'Configuration.h'

to see if your problem is gone.

@lcfm1
Copy link
Contributor Author

lcfm1 commented Apr 6, 2015

hmm... works. what it's mean?

@lcfm1
Copy link
Contributor Author

lcfm1 commented Apr 6, 2015

ok. I downloaded the latest build for today, filled in Arduino and nothing happened. screen clean. http://pastebin.com/fWTFBSET

@lcfm1
Copy link
Contributor Author

lcfm1 commented Apr 6, 2015

it did not work until I uncommented line #define REPRAP_DISCOUNT_SMART_CONTROLLER. it should be added to Conditionals.h

@AnHardt
Copy link
Member

AnHardt commented Apr 6, 2015

We can not define all dispays at once - they conflict with each other.
#define REPRAP_DISCOUNT_SMART_CONTROLLER
is the place to tell the compiler:
'Yes i have this display. Please switch it on for me.'

@AnHardt
Copy link
Member

AnHardt commented Apr 6, 2015

In Conditionals.h the magic happens that if REPRAP_DISCOUNT_SMART_CONTROLLER is defined, automatically all options you mentioned in your first posting will be defined.

@lcfm1
Copy link
Contributor Author

lcfm1 commented Apr 6, 2015

AnHardt, I think, for so many screens - it's time to start a separate procedure, by analogy with motherboards

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants