Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cold extrusion prevention not working #1846

Closed
fotis400 opened this issue Apr 7, 2015 · 6 comments
Closed

Cold extrusion prevention not working #1846

fotis400 opened this issue Apr 7, 2015 · 6 comments

Comments

@fotis400
Copy link

fotis400 commented Apr 7, 2015

Just tested it multiple times.

With my extruder cold, I send a command to extrude. The printer echoes that it prevented a cold extrude but it DOES extrude.

@boelle
Copy link
Contributor

boelle commented Apr 7, 2015

Not good... @thinkyhead you think you can spot why this one is happening?

@clefranc
Copy link
Contributor

clefranc commented Apr 7, 2015

Potential bug confirmed with #1847

@clefranc
Copy link
Contributor

clefranc commented Apr 8, 2015

It's the new e delta calculation https://github.com/MarlinFirmware/Marlin/blob/Development/Marlin/planner.cpp#L508

You need to recalculate the delta after the PREVENT_DANGEROUS_EXTRUDE block https://github.com/MarlinFirmware/Marlin/blob/Development/Marlin/planner.cpp#L510

I've put this on line 526

de = target[E_AXIS] - position[E_AXIS];

thinkyhead added a commit that referenced this issue Apr 8, 2015
- Set `de` to 0 when `position[E] = target[E]`
- Address regression mention in #1846
@thinkyhead
Copy link
Member

Fixed the delta e issue (in the above-linked commit).

@fotis400
Copy link
Author

fotis400 commented Apr 8, 2015

tested and works ok.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants