-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Input Shaping with I2S_STEPPER_STREAM #25605
Comments
Some additional observations:
|
IS is not supported with ESP32. My naive guess is the FT is not either. We should add a sanity check. ESP32 works around some of the core stepper logic. We really need a refactor of stepper.cpp that puts all the step generation in one place and prevents more than one step being generated per pass through the loop. Then ESP32 could be integrated with IS properly. (Not to mention baby stepping and really getting it working with LA.)
You could want to compile with |
I'll mark this as a feature request for
Added: |
I created #25358 to apply the related AVR sanity check to everything. |
All hardware currently using the ESP32 chipset is experiencing the same issue. This is because the ESP32 chipset communicates through the I2S Stream. Unfortunately, most EPS32s can't handle Marlin's I2S stream properly. Therefore, the following features are currently not implemented: 1.Incompatible with INPUT_SHAPING 2.Incompatible with Babystep 3.Incompatible with FT motion 4.Incompatible with Linear Advance And there are currently issues with inaccurate temperature sensors and layer shift issues. The ESP32 chipset has powerful processing performance, but unfortunately, only ARM or STM32 series are mainly developed in Marlin, so it's better not to use the ESP32 chipset until a capable person comes out. The reason why this board is inexpensive is because of the above reasons, and the manufacturer will no longer update after version 2.0.9. (There were some translation errors, so I re-edited some phrases.) |
@vfbank you weren't paying attention, LA and babystep are supported now |
@vfbank Your thinking is backwards, Need more controllers using esp32 to attract esp32 developers to the project |
Unfortunately, when I activate the extension, it compiles, but Babysteps still doesn't work. |
INTEGRATED_BABYSTEP still don't work on i2s? Someone send Tom TinyBee already! 😆 |
Enabling the INTEGRATED_BABYSTEPPING definition compiles but babystep doesn't work. No matter how much you turn the dial, only the value changes and the Z-axis does not move. Same goes for other features. The 2.1.2 key features listed above compile but do not actually work. If it works, please share the video and setting file that works for me. please. This issue has already been answered by asking the same issue in the TinyBee thread. Again, the problem is caused by the ESP32 chipset not properly supporting I2S streams. I2S function is not the problem. This issue should be addressed by the hardware manufacturer. |
For reference, the ESP32 hardware should control all communication with 32 pins. About 2-4 times less compared to ARM or STM32 processors. This causes layout configuration issues. The EPS32 chipset operates at an amazing 180Mhz speed and has Bluetooth/WIFI functions, but due to the size of the chipset, there is a problem in configuring the communication interface. The reason I think of it negatively is that I actually tried to improve it, but eventually gave up due to a lot of limitations. Improving the features won't be easy unless you're an engineer or developer with great skills. First of all, the Arduino core of the EPS32 chipset is still in the development stage, and there are numerous functional problems and hardware compatibility issues. The qualitative difference between ARM and STM32 chipsets and libraries with a long history is quite large. Marlin firmware works with Arduino to maintain compatibility with AVR boards. Therefore, in order to develop EPS32, efforts of hardware developers are desperately needed. However, they are not very interested in updating the Arduino core of the EPS32 (to be precise, the ESP-IDF development tools are too slow to update). The reason is probably financial. This is very sad. |
Maybe you meant framework? |
It seems to me that the ESP32 chipset's G-code processing part is the problem. Probably a data exchange problem (not sure) For better understanding, let's compare them in the same way as the G-code slicing program. Let's assume that the existing pure G-code (original source via SD card or USB) is modified with the desired function through post-processing. I need to intercept the original data (sorry English is not my native language, so I don't know how the translation will work) and replace that part with new G-code to get what I want. However, this part doesn't seem to work properly due to some problem. So, while the existing data is being processed, it seems that all related functions do not work because it cannot be changed in the part where it is to be changed by modulating it with other data. This is speculative, so it may not be correct. So I can't give you any good advice on this matter. sorry. *Once this issue is resolved, there will be many 3D printer motherboards using the ESP32 chipset. |
First I have some X axis improvements to make on my printer so I can print a 15ish minute benchy on 8 bit and 12V just to showcase how awesome Marlin is. Then I need to finish fixing my coffee machine and make a very niche youtube video for anyone else wanting to to do the same fix. And I want to get on with my variation on rq3's TAP-XXX bed sensor. Then it would be really great to look into why bugfix is still causing stepper issues for some users. And there's a weird E stepper thing that might be related to a backlash correction bug. And some memory improvements I've had in mind for ages. And smooth multistepping. And I've started contributing to another github project for head tracking for simulators. And I really should look over the FT stuff. And having a life. How did I get in so deep? 😮 |
At least you deserve some new shiny toys 😛 |
I'll be very happy to post a video of that to Twitter to steal a little of the limelight from Prusa who are arriving late to this party but getting all the jellybeans. |
Great, thanks Scott. I'll let you know. |
Did you test the latest
bugfix-2.1.x
code?Yes, and the problem still exists.
Bug Description
If Input shapıing is enabled, the printer will home x and then y axis. Then stops responding (does not home z).
Homing works fine if I send "M593 F0" before homing
Bug Timeline
It is existent in the 2.1.2 and the latest bugfix
Expected behavior
I expect it to home
Actual behavior
It stops responding during the homing routine.
Steps to Reproduce
enable input shaping and set it to a value >=1
Home the printer
Version of Marlin Firmware
2.1.2 or 2.1.bugfix
Printer model
Prusa clone (Bedslinger)
Electronics
Tinybee v3
Add-ons
Z-probe as Z-endstop
Bed Leveling
ABL Bilinear mesh
Your Slicer
Prusa Slicer
Host Software
Pronterface
Don't forget to include
Configuration.h
andConfiguration_adv.h
.Additional information & file uploads
will only respond after a reset.
Only other modification is That I have changed the ADC voltage to 2.585 as that gives correct values
Marlin.zip
The text was updated successfully, but these errors were encountered: