🚸 Add Input Shaping with I2S_STEPPER_STREAM warning #27051
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title states, add an Input Shaping with
I2S_STEPPER_STREAM
warning for ESP32-based motherboards like the MKS TinyBee.The warning is a bit inaccurate since it's a known issue that these are incompatible (and it just came up again on Discord), but I wanted to match the existing
FT_MOTION
+I2S_STEPPER_STREAM
warning:Marlin/Marlin/src/inc/Warnings.cpp
Lines 854 to 859 in eb781af
I originally tried to sanity check this in #25632, but the PR got hijacked and turned into something else, so it was closed.
Requirements
Any ESP32 motherboard like the MKS TinyBee with
I2S_STEPPER_STREAM
andHAS_ZV_SHAPING
(INPUT_SHAPING_X
/INPUT_SHAPING_Y
)Benefits
Warn users that these settings may be incompatible (but we know they're not).
Configurations
Any ESP32 motherboard like the MKS TinyBee with
I2S_STEPPER_STREAM
andHAS_ZV_SHAPING
(INPUT_SHAPING_X
/INPUT_SHAPING_Y
)Related Issues