Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] reduce min/max bounds for the editor of z-probe "x offset" and "y offset" #26263

Closed
vlsi opened this issue Sep 11, 2023 · 2 comments
Closed

[FR] reduce min/max bounds for the editor of z-probe "x offset" and "y offset" #26263

vlsi opened this issue Sep 11, 2023 · 2 comments
Labels
T: Feature Request Features requested by users.

Comments

@vlsi
Copy link
Contributor

vlsi commented Sep 11, 2023

Is your feature request related to a problem? Please describe.

Currently, ColorUI spawns an editor with BED SIZE minimal and maximal values for x offset.
First, it triggers #26262, and it is inconvenient at the same time.
If the scrollbar was smaller, then it would be way easier to edit the needed value.

Are you looking for hardware support?

No response

Describe the feature you want

I suggest adding //#define ZPROBE_XOFFSET_EDITABLE_BOUND 50 define to Configuration.h, and use 50 if the value is not provided.

Marlin/Marlin/src/lcd/menu/menu_advanced.cpp

Lines 631 to 632 in 11f98ad

EDIT_ITEM(float31sign, MSG_ZPROBE_XOFFSET, &probe.offset.x, -(X_BED_SIZE), X_BED_SIZE);
EDIT_ITEM(float31sign, MSG_ZPROBE_YOFFSET, &probe.offset.y, -(Y_BED_SIZE), Y_BED_SIZE);

Additional context

No response
@vlsi vlsi added the T: Feature Request Features requested by users. label Sep 11, 2023
vlsi added a commit to vlsi/reborn2-marlin that referenced this issue Sep 11, 2023
@vlsi
ADD Z_PROBE_OFFSET_XRANGE_MIN, Z_PROBE_OFFSET_XRANGE_MAX, Z_PROBE_OFF…
07091dc 
…SET_YRANGE_MIN, Z_PROBE_OFFSET_YRANGE_MAX to make UIs nicer, and limit M851 XY offsets

M851 would respect the limits, so the system would be safer.

Fixes MarlinFirmware#26263
@vlsi vlsi mentioned this issue Sep 11, 2023
Merged
vlsi added a commit to vlsi/reborn2-marlin that referenced this issue Sep 11, 2023
@vlsi
ADD Z_PROBE_OFFSET_XRANGE_MIN, Z_PROBE_OFFSET_XRANGE_MAX, Z_PROBE_OFF…
9acc105 
…SET_YRANGE_MIN, Z_PROBE_OFFSET_YRANGE_MAX to make UIs nicer, and limit M851 XY offsets

M851 would respect the limits, so the system would be safer.

Fixes MarlinFirmware#26263
vlsi added a commit to vlsi/reborn2-marlin that referenced this issue Sep 11, 2023
@vlsi
ADD Z_PROBE_OFFSET_XRANGE_MIN, Z_PROBE_OFFSET_XRANGE_MAX, Z_PROBE_OFF…
4cf0660 
…SET_YRANGE_MIN, Z_PROBE_OFFSET_YRANGE_MAX to make UIs nicer, and limit M851 XY offsets

M851 would respect the limits, so the system would be safer.

Fixes MarlinFirmware#26263
vlsi added a commit to vlsi/reborn2-marlin that referenced this issue Sep 11, 2023
@vlsi
ADD Z_PROBE_OFFSET_XRANGE_MIN, Z_PROBE_OFFSET_XRANGE_MAX, Z_PROBE_OFF…
c867de5 
…SET_YRANGE_MIN, Z_PROBE_OFFSET_YRANGE_MAX to make UIs nicer, and limit M851 XY offsets

M851 would respect the limits, so the system would be safer.

Fixes MarlinFirmware#26263
@vlsi
Copy link
Contributor Author

vlsi commented Sep 11, 2023

I've filed PR #26267, so moving the discussion there

@vlsi vlsi closed this as completed Sep 11, 2023
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
T: Feature Request Features requested by users.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vlsi