Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCD print timer does not stop #3061

Closed
jbrazio opened this issue Mar 1, 2016 · 9 comments
Closed

LCD print timer does not stop #3061

jbrazio opened this issue Mar 1, 2016 · 9 comments
Labels

Comments

@jbrazio
Copy link
Contributor

jbrazio commented Mar 1, 2016

When I print using serial the LCD timer starts but it never stops even when motor timeout kicks in a motors are turned off. Does anyone else experience this issue ? I'm using Marling RCBugFix.

@Blue-Marlin
Copy link
Contributor

What timer?
At the status line?
The messages there are send by the host/slicer. Just add a final M117 Ready to your g-code files or end-code.

When printing over the serial line Marlin has no way to know about starting or ending files and therefore has no own timer for that.

@jbrazio
Copy link
Contributor Author

jbrazio commented Mar 2, 2016

Not the status line, the timer which is activated when SD printing..

I see print_job_start_ms being started with M24, M31, M32 or with M109. When serial printing I don't explicit tell Marlin to start the print job timer on my g-code, it automatically does so when it sees the M109 heating the extruder. I see four possibilities for it to automatically detect my print has finished:

  1. Disable the auto start in M109 if serial printing
  2. By timeout Move distance shouldn't include E when XYZ are moving. #1 - the buffer/planner is empty for some time
  3. By timeout Hi #2 - the motors have gone into no-power mode
  4. By seeing the extruder go cold for instance with the M109 S0

@thinkyhead
Copy link
Member

This is a longstanding issue. When your print finishes, the LCD will read "1 hour 3 minutes" but the little clock will continue to tick after the print has finished. I like the idea of having the timer stop when all the extruder heaters have been turned off. So, not just on any M109 S0 but only the one that turns off the last heater.

@thinkyhead thinkyhead added PR: Improvement Needs: Work More work is needed labels Mar 2, 2016
@jbrazio
Copy link
Contributor Author

jbrazio commented Mar 2, 2016

Exactly it must for sure take into account all extruders.

Maybe we should also pay some attention to M104 as a start/stop for the print timer ? Don't know if people may start their g-code with M104 but for sure people may end their g-code with M104 has the way to turn off the extruders in a non blocking way.

@Blue-Marlin
Copy link
Contributor

Ahh, printing from SD.
Isn't closing the file a good indicator?

@jbrazio
Copy link
Contributor Author

jbrazio commented Mar 2, 2016

Not from SD.. from serial.

@Blue-Marlin
Copy link
Contributor

When I print using serial the LCD timer starts but it never stops

Not the status line, the timer which is activated when SD printing..

Not from SD.. from serial.

???

@jbrazio
Copy link
Contributor Author

jbrazio commented Mar 2, 2016

Each sentence has it's own context..
Issue: When I print using serial the LCD timer starts but it never stops

@Blue-Marlin

What timer?
The messages there are send by the host/slicer.

@jbrazio

Not the status line, the timer which is activated when SD printing..

@Blue-Marlin

Ahh, printing from SD.

@jbrazio

Not from SD.. from serial.

@thinkyhead nailed with "This is a longstanding issue. When your print finishes, the LCD will read "1 hour 3 minutes" but the little clock will continue to tick after the print has finished."

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants