Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move distance shouldn't include E when XYZ are moving. #1

Closed
wants to merge 2 commits into from
Closed

Conversation

jv4779
Copy link

@jv4779 jv4779 commented Aug 22, 2011

Distance calculation for moves don't include E axis unless it is the only axis moving.

Clip the max feedrate based on the firmwares max step frequency. Previously this was clipped in calc_timer which limited the speed indirectly. This lead to issues with estimate_acceleration_distance and intersection_distance overflowing the long type and making accelerate_until and decelerate_after bogus when large feedrates were used. The net effect is the firmware steps at the same rate as before, but does it in a sane manner. The under/overflow of accelerate_until was a major cause for the jerking observed. When this was negative the acceperation code tried to accelerate for the entire move causing acceleration_timer to hit zero, causing calc_timer to return a 32ms step spacing introducing a full to almost zero step rate change instantly.

jvangrin added 2 commits August 22, 2011 00:05
@jv4779
Copy link
Author

jv4779 commented Aug 26, 2011

Would you prefer I pushed to experimental?

@bkubicek
Copy link
Contributor

is this still an issue with the current beta 1 of v1.0.0 (see tags)?

@jv4779
Copy link
Author

jv4779 commented Nov 22, 2011

Yes. I checked the v1 code and it is still doing the distance wrong, which
will cause the speed to be lower than requested.
On Nov 22, 2011 1:40 PM, "Bernhard Kubicek" <
reply@reply.github.com>
wrote:

is this still an issue with the current beta 1 of v1.0.0 (see tags)?


Reply to this email directly or view it on GitHub:
ErikZalm#1 (comment)

@ErikZalm
Copy link
Contributor

ErikZalm commented Feb 9, 2012

I added the distance calculation correction. The steprate is limited in the stepper routine.

Thanks for this fix. Sorry it took so long to put it in the code.

@ErikZalm ErikZalm closed this Feb 9, 2012
ErikDeBruijn referenced this pull request in ErikDeBruijn/Marlin May 9, 2012
ErikZalm pushed a commit that referenced this pull request Nov 21, 2012
daid added a commit that referenced this pull request Mar 15, 2013
Fix step rate bug (especially for retraction)
illuminarti referenced this pull request in illuminarti/Marlin Mar 17, 2013
Fix step rate bug (especially for retraction)
LinuxBozo pushed a commit to LinuxBozo/Marlin that referenced this pull request Mar 17, 2013
* upstream/Marlin_v1:
  Merge pull request MarlinFirmware#1 from illuminarti/Fix_E_Speed
LinuxBozo pushed a commit to LinuxBozo/Marlin that referenced this pull request Mar 17, 2013
* Marlin_v1:
  Merge pull request MarlinFirmware#1 from illuminarti/Fix_E_Speed
fsantini pushed a commit to fsantini/solidoodle2-marlin that referenced this pull request May 6, 2013
Solidoodle 3 bed size with conditional switch
fsantini pushed a commit to fsantini/solidoodle2-marlin that referenced this pull request Dec 7, 2013
Full merge with base Marlin repo, latest commits
ErikZalm pushed a commit that referenced this pull request Mar 15, 2014
ErikZalm pushed a commit that referenced this pull request Aug 28, 2014
schmiddim added a commit to schmiddim/Marlin that referenced this pull request Aug 28, 2014
@galexander1 galexander1 mentioned this pull request Sep 3, 2014
@alexborro alexborro mentioned this pull request Nov 5, 2014
EiNSTeiN- pushed a commit to JDGETS/Marlin that referenced this pull request Dec 8, 2014
boelle pushed a commit that referenced this pull request Jan 6, 2015
rosenhouse pushed a commit to rosenhouse/Marlin that referenced this pull request Feb 16, 2015
@thinkyhead thinkyhead mentioned this pull request Feb 24, 2015
thinkyhead pushed a commit that referenced this pull request Mar 5, 2015
gnusenpai pushed a commit to gnusenpai/Marlin that referenced this pull request Oct 5, 2021
stklcode pushed a commit to stklcode/Marlin that referenced this pull request Sep 2, 2022
…advanced pause and parging feature and fixed bug, which prevents resuming from pared nozzle.
qw3rtrun referenced this pull request in qw3rtrun/Marlin Sep 7, 2022
qw3rtrun referenced this pull request in qw3rtrun/Marlin Sep 7, 2022
Add a preheating function to repair the error returned by the bltouch…
LennartHennigs referenced this pull request in LennartHennigs/Marlin Sep 18, 2022
JorgenBergman added a commit to JorgenBergman/Marlin that referenced this pull request Oct 3, 2022
blastrock pushed a commit to blastrock/Marlin-sv06 that referenced this pull request Feb 3, 2023
Link to model of runout sensor mount
classicrocker883 referenced this pull request in classicrocker883/Marlin Apr 9, 2023
BotchedRPR added a commit to BotchedRPR/marlin-filaprinter that referenced this pull request Jul 14, 2023
drewmoseley pushed a commit to drewmoseley/Marlin that referenced this pull request Nov 8, 2023
JonBr306 referenced this pull request in JonBr306/Marlin May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants