Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Float compare to 0.0 #49

Closed
Mooselake opened this issue Jan 15, 2012 · 1 comment
Closed

Float compare to 0.0 #49

Mooselake opened this issue Jan 15, 2012 · 1 comment

Comments

@Mooselake
Copy link

Not a big issue, but while looking at motion_control.cpp, function mc_arc (line 48) is a test for float == 0.0.

Wouldn't millimeters_of_travel< some_very_small_number be more appropriate, where some_very_small_number could be close to the size of a single step?
@ErikZalm ErikZalm closed this as completed Feb 9, 2012
thinkyhead referenced this issue in thinkyhead/Marlin Sep 6, 2019
@Msq001
Merge pull request #49 from MarlinFirmware/bugfix-2.0.x
4552b72 
sync Bugfix 2.0.x
fran6p pushed a commit to fran6p/Marlin that referenced this issue Dec 27, 2020
@Sebazzz
Prevent removing SD card while printing from host causing return to m…
41c3d5d 
…ain menu . Fixes MarlinFirmware#49.
tonokip pushed a commit to ultimachine/Marlin that referenced this issue Jan 24, 2022
@bmkahl
Merge branch '49-lcd-screen-is-unreadable-sometimes-sk289' into 'master'
9d0462b 
Resolve "LCD screen is unreadable sometimes SK289"

Closes MarlinFirmware#49

See merge request lulzbot3d/marlin!28
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ErikZalm @Mooselake