Request for Configuration.h version reporting during startup

[hairykiwi]

This issue is now solved.

A pull request might be submitted shortly. In the meantime try the code below.

[hairykiwi]

Between submitting this request and working out a solution, the configuration_adv.h file has been introduced. Rather than make more work for myself, here's the solution I implemented in the version of Marlin from two days ago.

For the record: Implementation of an idea by Prof Braino

In Marlin.pde
#define STRING_VERSION "1.0.0 Beta 1
becomes:
#define STRING_VERSION_MARLIN "1.0.0 Beta 1

then in Marlin.pde void setup()

find/replace until the last line below:

  SERIAL_ECHO_START;
  SERIAL_ECHOLN("Version Info");
  SERIAL_ECHO("Marlin: ");
  SERIAL_ECHOLNPGM(STRING_VERSION_MARLIN);
  SERIAL_ECHO("Configuration.h: ");
  SERIAL_ECHOPGM(STRING_VERSION_CONFIG_H);
  SERIAL_ECHO(" | Author: ");
  SERIAL_ECHOLN(STRING_VERSION_CONFIG_H_AUTHOR);
  SERIAL_ECHO("Free Memory:");

At top of configuration.h add:

  //Implementation of an idea by Prof Braino to inform user that any changes made
//to THIS file by the user have been successfully uploaded into firmware.
#define STRING_VERSION_CONFIG_H "2012-02-08j" //Personal revision number for changes to THIS file.
#define STRING_CONFIG_H_AUTHOR "username" //Who made the changes.

This solution could obviously be extended to include changes made to the configuration_adv.h file as well.

[ErikZalm]

I think this is a good idea. I will implement it.

[ErikZalm]

I implemented it.
For some strange reason I can not print "Version". pronterface does not like that.

[hairykiwi]

Great! The addition of #ifdef is a nice idea.

By "Version" are you referring to the following line?
SERIAL_ECHOLN("Version Info");

Also - my interpretation of the definitions in Marlin.h for SERIAL_ECHOxxxxx & SERIAL_PROTOCOLxxxxx
is that those functions ending in PGM take a reference to a function as an argument, whereas those without accept a string. Therefore, by my understanding, the 'PGM' version of these functions is not required, for these and similar lines (and maybe that's why you couldn't get Version to print?):
SERIAL_ECHOPGM("Marlin: ");
SERIAL_ECHOPGM("Marlin: ");

The code I posted earlier worked fine for my Win (Python) version of Pronterface. Does me using XP explain any difference in what we see in Pronterface perhaps?

Also, I didn't understand the need for
SERIAL_PROTOCOLLNPGM("start");
hence it's removal. Neither did excluding the second SERIAL_ECHO_START;
just before SERIAL_ECHOPGM("Free Memory:");
appear to have any effect, hence I thought I'd try with it removed.

Cheers, Hamish

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.