UltraLCD enhancements (fan as percent, add backlash menu) #13519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marcio-ao
commented
Mar 28, 2019
•
marcio-ao
commented
- Added UltraLCD editor type for showing full scale (0-255) uint8_t values as percentages (0%-100%)
- Show fan speed editor as percentage for consistency with status screen
- Changed backlash correction amount from float to uint8_t (save 3 bytes SRAM)
- Added backlash menu to UltraLCD (makes use of new UltraLCD percentage editor)
marcio-ao
force-pushed
the
pr-ultralcd-percentage
branch
from
39a95f2
to
1df7ac7
Compare
- Show fan speeds as a percentage from 0% to 100% rather than 0 to 255
- Saves 3 bytes of SRAM. - Consistent with fan speed.
marcio-ao
force-pushed
the
pr-ultralcd-percentage
branch
from
1df7ac7
to
5a126c8
Compare
marcio-ao
changed the title
AnHardt
reviewed
Aug 17, 2019
| @@ -395,21 +395,21 @@ void menu_temperature() { | |||
| // | |||
| #if FAN_COUNT > 0 | |||
| #if HAS_FAN0 | |||
| MENU_MULTIPLIER_ITEM_EDIT_CALLBACK(uint8, MSG_FAN_SPEED FAN_SPEED_1_SUFFIX, &thermalManager.lcd_tmpfan_speed[0], 0, 255, thermalManager.lcd_setFanSpeed0); | |||
| MENU_MULTIPLIER_ITEM_EDIT_CALLBACK(percent, MSG_FAN_SPEED FAN_SPEED_1_SUFFIX, &thermalManager.lcd_tmpfan_speed[0], 0, 255, thermalManager.lcd_setFanSpeed0); | |||
| #if ENABLED(EXTRA_FAN_SPEED) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.