Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missed comments in fwretract.cpp #13802

Merged
merged 2 commits into from
Apr 26, 2019
Merged

fix missed comments in fwretract.cpp #13802

merged 2 commits into from
Apr 26, 2019

Conversation

chai-md
Copy link
Contributor

@chai-md chai-md commented Apr 24, 2019

G10 S1 command after G10 is ignored.
Some commented debug messages are unable to compile with error.

@chai-md chai-md changed the title fix wrong comments in fwretract.cpp fix missed comments in fwretract.cpp Apr 24, 2019
@thinkyhead
Copy link
Member

Some commented debug messages are unable to compile with error.

SERIAL_ECHOLNPAIR can take several arguments. The code as written should work.

@thinkyhead thinkyhead merged commit ed9eaa1 into MarlinFirmware:bugfix-2.0.x Apr 26, 2019
@chai-md chai-md deleted the fwretract branch January 6, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: General Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chai-md @thinkyhead