Fix PLR file delete bug #13860
Merged
Fix PLR file delete bug #13860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbycandra
changed the title
thinkyhead
changed the title
ozgunawesome
pushed a commit
to ozgunawesome/Marlin
that referenced
this pull request
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we print file from sub folder, 2 things happened.
After printing finished, or we Stop Printing, PLR file delete will fail.
This is because current code try to delete PLR file at Working Directory.
This PR just add simple fix by add "/" at the beginning of Filename.
After first resume, marlin will fail on second resume.
After first resume, Marlin save Filename without Directory.
This happened because workDirParents is not set.
Therefore when writing PLR
card.getAbsFilename(info.sd_filename);will only write Filename Part without Directory.
Problem no 1 is fixed by this PR.
But problem no 2 is not fixed yet.