settings: store runout sensor on/off #13876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, it could be useful to keep it disabled on start
|
Now that this is stored in EEPROM the |
|
yes, if its really bugging users, we could patch the default value to true... but this feature is not a requirement to print... |
|
maybe the solution could be to store runout_sensor_disabled instead of enabled... to keep current default behavior |
|
Oh, right. The sensor is enabled by default. So, it will be |
|
I think we put the variable in wrong order. (wrong place) It should be above or below |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, it could be useful to keep it disabled on start.
Sample: i'm actually experiencing issues on print start/resume with the power loss recovery feature if the sensor is enabled.
This on/off is in configuration menu, but was not stored for now...