Hide 'vsense' report row if not used #13884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR needs a bit more work to account for mixed driver configurations. |
|
Oops, Sorry. You are right, I didnt thougt about mixed drivers |
thinkyhead
reviewed
May 5, 2019
| @@ -793,7 +793,9 @@ | |||
| #endif | |||
| TMC_REPORT("CS actual\t", TMC_CS_ACTUAL); | |||
| TMC_REPORT("PWM scale", TMC_PWM_SCALE); | |||
| TMC_REPORT("vsense\t", TMC_VSENSE); | |||
| #if HAS_DRIVER(TMC2130) || HAS_DRIVER(TMC2224) || HAS_DRIVER(TMC2660) || HAS_DRIVER(TMC2208) | |||
There was a problem hiding this comment.
This is the first reference we have to TMC2224. Are there other elements that go along with this?
There was a problem hiding this comment.
I put HAS_DRIVER(TMC2224) in here just for completeness, as they are supported by the TMCStepper library.
Sorry, I dont understand what you mean with: Are there other elements that go along with this?
thinkyhead
changed the title
ozgunawesome
pushed a commit
to ozgunawesome/Marlin
that referenced
this pull request
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty vsense report is removed from M122 for TMC2160 and TMC5160, because vsense does not exist for these drivers. Preventing user confusion
Related Issues
#13883