BLTouch.init() should not deploy #13988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Low or unknown probe clearance on init (even at powerup) is a risk and therefore, a deploy should be avoided because dragging the pin is possible: A deploy goes into alarm if it can*t extend fully and then the subsqeuent stow will fail.
|
New status after testing the new BLTouch V3.1: This PR is not affected. It is still needed ASAP |
ghost
mentioned this pull request
ghost
deleted the
ozgunawesome
pushed a commit
to ozgunawesome/Marlin
that referenced
this pull request
May 29, 2019
Low or unknown probe clearance on init (even at powerup) is a risk and therefore, a deploy should be avoided because dragging the pin is possible: A deploy goes into alarm if it can't extend fully and then the subsequent stow will fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #13983 ([BUG] BLTouch deploys and stows before homing X and/or Y)
A
bltouch.init()at a time of low or unknown probe clearance (EVEN AT PRINTER POWERUP) is a risk and therefore, a deploy should be avoided because dragging the pin is possible: A deploy goes into alarm if it can't extend fully and then the subsqeuent stow will fail.So inside
bltouch.init(), instead ofclear()which translates toreset-stow-deploy-stowit is better to just doreset-stow.This (new similar) case is just one more (and hopefully the final one) of these cases where the use of
init()is overkill or detrimental. See #13959 (BLTOUCH Less is as good).This one is so urgent that I didn't want to just add it to that PR. I think it needs reviewing separately and addressing a lot sooner.