-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLTouch V3.1 changes #14104
BLTouch V3.1 changes #14104
Conversation
Ok, I think this now encompasses everything that was left open. Works good across the 3 machines I tried it on. Feel free to beat up anything I missed @FanDjango |
Ok, not sure why a rebase now shows tons more differences... Maybe @thinkyhead can answer that one better... |
Githib is dumb, I literally grabbed a 30s old archive of the repo, copied gcode.h and M916-918.cpp into this and pushed it and it still shows theyre different.... |
When rebasing, first make sure you have the latest bugfix in all the places:
If you take a note of the HEAD commit before you try to rebase, you can always get back to it with:
Once you get back to where you started from, you can first squashed everything down to a single commit. One way to do this is with interactive rebase. For example, to squash 4 commits down to 1 you might just start 4 commits back in time…
If you have your changes down to a single commit, you can start afresh and just try applying the one commit to the latest HEAD…
When all else fails, you can usually get most of the way there with Once any branch is cleaned up and rebased on
|
6910793
to
32006da
Compare
Rebased and squashed! To get this into your working copy:
|
32006da
to
932ea86
Compare
@thinkhead It would be helpful to merge this branch when possible. It is my belief everybody that has been working on the BL-Touch issues is in agreement these changes make sense. |
932ea86
to
7d9c845
Compare
Should have known youd get it fixed before I could!!! lol https://github.com/InsanityAutomation/Marlin/tree/BLTouchV31Rebased At least I cooked bacon in the meantime.... |
7d9c845
to
87b0669
Compare
Well, I will leave this be and see how it does with Travis CI. BLTouch options are multiplying and it might be good to move them to |
How about a compromise? I agree with the high level direction. But it would be helpful to get the working code merged. How about we merge, and the next Pull Request moves the options to the Configuration_adv.h file? |
Im good with that, and ill probably use the dialog that sd start and stop have now for setting drain mode in the next PR so we have text room for a big warning! |
And we have a happy travis now |
Continuation here from #14064
Picking up as @FanDjango is expecting to be occupied for the next few days.
@thinkyhead @Roxy-3D @Bob-the-Kuhn