Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtUI Heated Chamber support #14198

Merged

Conversation

InsanityAutomation
Copy link
Contributor

Extend heater functions with CHAMBER support
Add tests to DUE platform for EXTENSIBLE_UI
Fix scope issue of synchronize function thats only for SPI_LCD's

@InsanityAutomation
Copy link
Contributor Author

One thing I noticed doing this, heated chamber does not have an idle timeout. Was this intentional or should it be added?

@thinkyhead
Copy link
Member

Do you think the heated chamber should be paused when a print is paused? It sounds like a bad idea for materials requiring a heated chamber.

@ManuelMcLure
Copy link
Contributor

IMHO only the hotend should be paused. Bed and chamber should remain heated.

@InsanityAutomation
Copy link
Contributor Author

InsanityAutomation commented May 31, 2019

I would agree for pause during a print job and such, I bring it up primarily because I would think it's also a bad idea for the bed yet the idle timer stuff for the bed exists. For consistency's sake I considered if it was desirable. Could have an idle timeout when the print job timer is not paused so that somebody doesn't accidentally leave the chamber heated for 3 days with nothing going....

Just an observation and passing thought though. I'll leave things as they are and just ignore it for now unless somebody asks for it specifically.

@thinkyhead thinkyhead merged commit 66e22d9 into MarlinFirmware:bugfix-2.0.x Jun 7, 2019
@thinkyhead thinkyhead changed the title Add heated chamber support to ExtUI ExtUI Heated Chamber support Jun 7, 2019
@InsanityAutomation InsanityAutomation deleted the ExtUIHeatedChamber branch September 17, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants