Fix missing temperature icon for LCM1602 and smaller LCD's #14859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using CUSTOM_LCD_SIZE condition
|
We already auto-detect the width and height of the LCD based on model. Instead of adding a custom option, simply get the configurations from the original bug report and see which LCD selection has the problem, then add the appropriate conditions to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using CUSTOM_LCD_SIZE condition
Description
As reported by Eszartek, #14850, on 16x2 LCD displays, the temperature icon is missing. Added a CUSTOM_LCD_SIZE condition to address this issue.
Benefits
Fixes missing icon for smaller LCD displays
Related Issues
#14850