Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mega Port J endstop interrupts #15758

Merged
merged 2 commits into from
Nov 2, 2019
Merged

Fix mega Port J endstop interrupts #15758

merged 2 commits into from
Nov 2, 2019

Conversation

GMagician
Copy link
Contributor

PJ pins are D14 and D15 not D13 and D14, so all new logic has to be changed.

This fix #15750

PJ pins are D14 and D15 not D13 and D14, so all logig has to be changed
@GMagician
Copy link
Contributor Author

Not sure .ino is correct since macro is not used in Marlin

@thinkyhead
Copy link
Member

thinkyhead commented Nov 2, 2019

Please verify that these changes build ok in Arduino 1.8.10 with ENDSTOP_INTERRUPTS_FEATURE enabled. Previous change was to address Arduino 1.8.10.

EDIT: Seems good…

@thinkyhead thinkyhead merged commit 65ef774 into MarlinFirmware:bugfix-2.0.x Nov 2, 2019
@thinkyhead thinkyhead changed the title Fix mega interrupt handling on PJ Fix mega Port J endstop interrupts Nov 2, 2019
@GMagician GMagician deleted the avr-interrupt-fix branch November 2, 2019 14:49
philippniethammer pushed a commit to philippniethammer/Marlin that referenced this pull request Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants