Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.1.x] Add korean Support #15918

Merged
merged 3 commits into from
Nov 20, 2019
Merged

[1.1.x] Add korean Support #15918

merged 3 commits into from
Nov 20, 2019

Conversation

portalab
Copy link

@portalab portalab commented Nov 17, 2019 •
edited
Loading

Add korean Support

Requirements

You need a FULL GRAPHIC CLCD

Description

This feature supports Korean CLCD on FULL GRAPHIC LCD likes RepRapDiscount FULL GRAPHIC Smart Controller

Font : Copyright (c) 2010, NAVER Corporation (https://www.navercorp.com/) , NanumGothic, SIL OPEN FONT LICENSE

Benefits

You cau use Korean UI on GLCD
#15629_3
(Main Info)
#15629_1
(On Thermal Runaways)

Related Issues

#15629

[1.1.x] Add korean Support
930fba4 
Add korean Support
@boelle
Copy link
Contributor

boelle commented Nov 17, 2019

please send this to the 2.0.x branch instead, the other branches do not get updates anymore

@portalab
Copy link
Author

This PR is for user who wants to use korean in 1.1.x version. Many People still use 1.1.x version but Not support korean (only in 2.0.x). So It would be great if other korean users still in 1.1.x use this contribution. :)

@boelle
Copy link
Contributor

boelle commented Nov 17, 2019

but 1.1.x version will not get more updates,

why not use 2.0.x if it has korean? its both 8 bit and 32 bit

@portalab
Copy link
Author

portalab commented Nov 17, 2019 •
edited
Loading

I think marlinfw is great and many people use them, but some people (at lease my frineds) they aren't professional. they don't have programming or engineering skills. and they depend on manafactures's stock firmware come's out together and many forum's problem solving reference.
So It is so hard to makes configuration files themselves and solve problem if they have. In this situation I want to makes more easier using 3D printer for legacy korean user.

@thinkyhead
Copy link
Member

thinkyhead commented Nov 20, 2019 •
edited
Loading

Thanks @portalab ! — While there may not be a formal 1.1.x release planned, we continue to accept fixes to breaking issues in bugfix-1.1.x and anything that fills in a missing piece without adding a whole new feature. This qualifies as a welcome enhancement, and your work is appreciated. Will merge soon…

@thinkyhead thinkyhead merged commit aec1889 into MarlinFirmware:bugfix-1.1.x Nov 20, 2019
TiagoJustino added a commit to TiagoJustino/Marlin that referenced this pull request Apr 2, 2020
@TiagoJustino
Merge remote-tracking branch 'MarlinFirmware/1.1.x' into 1.1.x
8748e25 
* MarlinFirmware/1.1.x: (133 commits)
  Fix Z position after ABL bilinear G29 with fade (MarlinFirmware#17174)
  Change DUMMY_PID_VALUE to NAN (MarlinFirmware#17079)
  Disable integration testing
  Enable DUAL_NOZZLE_DUPLICATION_MODE (MarlinFirmware#16436)
  [1.1.x] Polish language UTF8 (MarlinFirmware#16141)
  Links for the "New Issue" page
  Add Korean language (MarlinFirmware#15918)
  [1.1.x] MKS_GEN_L_V2 controller (MarlinFirmware#15805)
  Update bug_report.md
  [1.1.x] Fix autostart w/out SD_DETECT_PIN (MarlinFirmware#15667)
  [1.1.x] RAMPS + Viki1 LCD compatibility (MarlinFirmware#15736)
  [1.1.x] Fix compiler warning (MarlinFirmware#15642)
  [1.1.x] Fix for G2/G3 rounding error (MarlinFirmware#15546)
  Let MINIPANEL use SW SPI if needed (MarlinFirmware#15246)
  Fix BLTouch debugging (MarlinFirmware#15232)
  Fix Creality bed thermistor
  Fix PT-BR strings (MarlinFirmware#15023)
  Fix #else extra tokens (MarlinFirmware#15013)
  [1.1.x] Autobuild formatting (MarlinFirmware#14858)
  [1.1.x] BLTouch 3.0 - 3.1 (MarlinFirmware#14839)
  ...
maz3max pushed a commit to maz3max/Marlin that referenced this pull request Aug 24, 2021
@coding-pivo
Add Korean language (MarlinFirmware#15918)
5c1baa4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: Language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@portalab @boelle @thinkyhead