Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMCStepper 0.6.x is now Marlin-compatible #15950

Merged
merged 2 commits into from
Nov 20, 2019
Merged

TMCStepper 0.6.x is now Marlin-compatible #15950

merged 2 commits into from
Nov 20, 2019

Conversation

swilkens
Copy link
Contributor

Description

TMCStepper 0.6.0 released with connection errors on some platforms, release 0.6.1 fixes these issues.

Benefits

Prevent TMCStepper connection errors on some platforms.

Related Issues

teemuatlut/TMCStepper#93

@swilkens swilkens closed this Nov 19, 2019
@swilkens swilkens reopened this Nov 19, 2019
@sjasonsmith
Copy link
Contributor

I suggest simply requiring >= 0.6.1, to avoid the possibility of building with 0.6.0, which is broken for many people. This is just my opinion, it's ultimately up to thinkyhead what strictness he wants.

You should also update BIGTREE_SKR_PRO, LPC1768, and LPC1769 to use the same dependencies. The custom fork is no longer needed for the LPC boards, since @p3p's fix was merged into TMCStepper.

@sjasonsmith
Copy link
Contributor

Also, a huge benefit of this is that it enables single-pin software serial on AVR.

@thinkyhead
Copy link
Member

According to discussion on Discord the stepper constructors have been updated for full compatibility with TMCStepper 0.6.x yet.

@thinkyhead thinkyhead merged commit e9bd6ef into MarlinFirmware:bugfix-2.0.x Nov 20, 2019
@thinkyhead thinkyhead changed the title Allow TMCStepper up to 0.6.1 TMCStepper 0.6.x is now Marlin-compatible Nov 20, 2019
philippniethammer pushed a commit to philippniethammer/Marlin that referenced this pull request Dec 21, 2019
christran206 pushed a commit to christran206/Marlin2.0-SKR-Mini-E3-1.2 that referenced this pull request Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants