Added initial version of MMU2S feature #17523

tonihoang · 2020-04-13T13:57:17Z

Requirements

When the filament reaches the gears, "A" needs to be sent to the MMU2

Description

After initalization of MMU (state -4 reached) in state 1,2, and 3 and the end filament runout sensor is checked.

On the first time it is triggered "A" is send to MMU2. If the user is in calibration mode, this will enable the automatic bowdentube length for MMU2.

Benefits

MMU2S usability

Related Issues

#15614

vertigo235 · 2020-04-13T15:57:39Z

Make sure you add the load more procedure that pushes the filament forward and then back to make sure the filament path is clear. This is the most important improvement with the MMU2S.

tonihoang · 2020-04-13T18:34:37Z

@vertigo235 do you have an example there? As I do not have a MK3S I do not know what behaviour you are referring to.

Where do you need to push it in the MMU or on the extruder?

I guess on the extruder you can edit the "MMU2_LOAD_TO_NOZZLE_SEQUENCE" in the Configuration_adv.h?, but i guess we'd need to add some additional checks then?

or do you mean to tell the MMU2 to load more filament?

BastR · 2020-04-13T19:04:05Z

@tonihoang

That's a hell of a coincidence. I've been working on this for a week too.
First of all, I've only been coding for a very short time so my code probably needs some work. However, it works perfectly at home, I used the history of the mmu.cpp file of the prusa firmware to add the filament sensor.
I’ve made a test print and It works.

That's the way it works:

Tn commands from the gcode
Tool change function in mmu2.cpp
I make an unload before activating the filament detection
MMU2 send ok when filament is unloaded
Tn command sent to the MMU
Filament is pushed is the bowden

Then 2 options:
1-If filament sensor detect the filament, Marlin send ‘A’ command to MMU to abort loading, finally MMU make last C0 command to push filament into gears
OR
2-if filament is not detected, MMU make N C0 command (defined by user in configuration_adv.h) to push more filament to reach sensor. If finally filament is not detected, the printer enter in runout.

It is also possible that some of the additions I've made are useless, I'll let you have a look so that you can give your opinion.

Thank you

https://github.com/BastR/Marlin/tree/Titan2.0?files=1

vertigo235 · 2020-04-13T19:18:58Z

@tonihoang This is the relevant function in prusa FW, once he IR sensor is deteced as 1 (loaded to gears), the extruder pushes the filament forward 60mm into the hotend, it then pulls the filament back 52mm. If there was a jam or obstruction then the filament would be pulled out past the gears (resulting in 0 on the IR sensor), if it moved at least 52mm forward (no obstruction), then the sensor would stay in state of 1 the whole time. This is a successful load and the print continues. If it's a failed load it will retry like 3 times before asking for attention.

https://github.com/prusa3d/Prusa-Firmware/blob/MK3/Firmware/mmu.cpp#L1440-L1483

tonihoang · 2020-04-13T21:10:36Z

I have copy pasta'd the can_load function, and adapted it to the marlin MMU module but too late today to integrate and continue, so I did a micro commit, in case of fire 🔥

@BastR I did not have time to check your stuff yet

tonihoang · 2020-04-14T10:01:42Z

I have only tested via Menu so far, and tested the "clogged state" via unplugging the sensor. but it fells somewhat useable, so i'll set it to ready for review for now.

@thinkyhead thanks for the overnight review and fixes

BastR · 2020-04-14T10:41:24Z

@tonihoang thanks you for your work, can you make change in some language files too?

"MSG_MMU2_LOAD_FILAMENT" can be confusing on the LCD because the message is "LOAD FILAMENT" while real means is "LOAD FILAMENT TO MMU".

In this commit I have made some changes if it helps: https://github.com/BastR/Marlin/commit/31b7462a7dc3d4f8128634ead372980d4814ab94

tonihoang · 2020-04-14T10:50:30Z

@tonihoang thanks you for your work, can you make change in some language files too?

"MSG_MMU2_LOAD_FILAMENT" can be confusing on the LCD because the message is "LOAD FILAMENT" while real means is "LOAD FILAMENT TO MMU".

In this commit I have made some changes if it helps: BastR@31b7462

maybe just create a separate PR for language text update? I'd prefer to keep this one a feature thing, and then you can update the text in a separate one?

BastR · 2020-04-14T10:58:37Z

@tonihoang thanks you for your work, can you make change in some language files too?

"MSG_MMU2_LOAD_FILAMENT" can be confusing on the LCD because the message is "LOAD FILAMENT" while real means is "LOAD FILAMENT TO MMU".

In this commit I have made some changes if it helps: BastR@31b7462

maybe just create a separate PR for language text update? I'd prefer to keep this one a feature thing, and then you can update the text in a separate one?

Yes you’re right, there's no hurry. I'll try to do it later then.👍🏻

BastR · 2020-04-21T12:46:56Z

I've made some tests.

Inicial load work has expected but when switching to the next filament, MMU2 act like sensor is already triggered:

(octoprint terminal log)

> Send: T0
Recv: MMU <= T0
Recv: MMU <= 'A'
[...]
Recv: MMU => 'ok'
Recv: MMU <= 'C0'
[...]
Recv: MMU => 'ok'
Recv: MMU <= 'C0'
[...]
Recv: MMU => 'ok'
Recv: MMU <= 'C0'
[...]
Recv: MMU => 'ok'
Recv: MMU <= 'C0'
[...]
Recv: MMU => 'ok'
Recv: MMU <= 'C0'
[...]
Recv: MMU => 'ok'
Recv: MMU <= 'C0'
[...]
Recv: MMU => 'ok'

This is "normal" because the tool change is operated with MMU2::tool_change who send command(MMU_CMD_T0 + index) and then make check_filament() systematically, as the filament is already present when he start T command so the A command is sent to the MMU2. The MMU2 finishes discharging the filament from the nozzle but acts as if it were still present (command A).

In the Prusa firmware there is a condition called mmu_loading_flag that temporarily activates or deactivates the filament sensor when changing tools to avoid this.

tonihoang · 2020-04-21T16:20:39Z

I've made some tests.

thanks for the input, I did not notice this, as prusaslicer creates a ramming sequence which unloads the filament, on my G-Codes. I am still fighting with it as it causes the PTFE tube to jam, now waiting for my tube with wider inner diameter.

Don't know when I have time to add this yet.

tonihoang · 2020-04-22T17:59:38Z

I've made some tests.

thanks for the input, I did not notice this, as prusaslicer creates a ramming sequence which unloads the filament, on my G-Codes. I am still fighting with it as it causes the PTFE tube to jam, now waiting for my tube with wider inner diameter.

Don't know when I have time to add this yet.

does anyone know the history here? it states in the comments that for toolchange it does not run the after load sequence as well, so I would assume also not to run unload? from running anything and expect GCode to be suitable?

BastR · 2020-04-22T20:51:49Z

does anyone know the history here? it states in the comments that for toolchange it does not run the after load sequence as well, so I would assume also not to run unload? from running anything and expect GCode to be suitable?

I'm sorry, but I don't understand

GMagician · 2020-04-26T07:29:52Z

Marlin/src/feature/mmu2/mmu2.cpp

+  bool MMU2::load_to_gears() {
+    command(MMU_CMD_C0);
+    manage_response(true, true);
+    LOOP_L_N(i, MMU2_C0_RETRY) {  // Keep loading until filament reaches gears


isn't here missing a check_filament call? before loop?
otherwise isn't the if () break; to be put after check_filament call?

isanval · 2020-07-06T18:31:09Z

How is PRUSA_MMU2_S_MODE supposedly to work? I mean, with MK3S and MMU2S the filament sensor is on the idler of the extruder.

When a Tx command is executed in Marlin, Marlin will send Tx/C0 commands to MMU2S and it will load the filament up to the nozzle, but while MMU2S is loading the filament, the extruder gears shouldn't be spining for an easy filament load into the extruder? I mean, if the extruder gears are not spining the MMU2S unit won't be able to insert the filament into the extruder and the sensor wouldn't be triggered.

GMagician · 2020-07-06T19:23:56Z

I think ir sensor logic is done by enabling MMU_EXTRUDER_SENSOR

isanval · 2020-07-06T20:34:16Z

There are 2 posible sensors. The "MMU_EXTRUDER_SENSOR" is the one just before the extruder gears, and PRUSA_MMU2_S_MODE is the extruder idler sensor.

The first one has no resistance, it smoothly detects the filament.

But the second one needs a lot of torque to get the filament in or, the best option, to get the extruder gears spining while the filament is loaded until the sensor is triggered.

I want to test it myself, I need to spin the extruder gears as soon the C0 command is triggered and until the Abort command is received from the MMU2 unit. I identified the points in the source code where I should do the "spin/stop spin the gears" instructionsm, but I have no idea how to program this.

GMagician · 2020-07-06T20:44:37Z

AFAIK MMU_EXTRUDER_SENSOR is the ir sensor that detect filament inside gears

isanval · 2020-07-06T20:50:35Z

From Configuration_adv.h I do not understand it as you say:

/**
 * MMU Extruder Sensor
 * Add support for Prusa IR Sensor (or other) to detect that filament reach the extruder to make loading filament more reliable
 * If your extruder is equipped with a filament sensor located less than 38mm from the gears you can use this feature
 * During loading to the extruder, the sensor will stop the loading command when he's triggered and make a last move to load filament to the gears
 * If no filament is detected, MMU2 will make more loading attemps, if finally no filament is detected, the printer will enter in runout state
 */

//#define MMU_EXTRUDER_SENSOR

/**
 * Using a sensor like the MMU2S
 * This mode only work if you have a MK3S extruder with sensor sensing the extruder idler mmu2s
 * See https://help.prusa3d.com/en/guide/3b-mk3s-mk2-5s-extruder-upgrade_41560, step 11
 */

//#define PRUSA_MMU2_S_MODE

In this video, MK3S and MMU2S you can see how the extruder gears are spining while the filament is being loaded:
https://www.youtube.com/watch?v=o7ghfPBW_AE#t=2m10s

GMagician · 2020-07-06T21:01:48Z

right, sorry

isanval · 2020-07-07T09:46:49Z

Any way to get the extruder gears spining in PRUSA_MMU2_S_MODE while the Tx/C0 commands until the filament sensor is triggered?

How could I extrude slowly until the filament sensor is triggered? Any C functions in Marlin that can do that?

isanval · 2020-07-08T18:41:49Z

@kakou-fr I saw in 15149 that you were having the same problem than I'm facing now.

Did you get the MMU2S working with the filament sensor on the idler?

kakou-fr · 2020-07-08T20:56:02Z

@kakou-fr I saw in 15149 that you were having the same problem than I'm facing now.

Did you get the MMU2S working with the filament sensor on the idler?

i think it's implemented in the bugfix version ?

GMagician · 2020-07-08T21:03:37Z

i think it's implemented in the bugfix version ?

Yes bugfix has added ir-sensor on filament inside bontech gears

isanval · 2020-07-09T07:00:48Z

Thanks @kakou-fr and @GMagician for your response. I'm using the bugfix version dated from 2020-06-27.

Maybe I'm missing something, but the problem here is that when MMU is executing the C0 command the printer extruder is not spining, so the MMU unit is not able to push the filament into the extruder (it has no enough torque for that).

From my point of view, the solution would be to spin slowly the extruder gear while MMU is executing the C0 command and until the filament inside the bondtech gears is triggered. From my understanding, this is how MK3S/MMU2S works.

I'm doing something wrong? Is someone using the MMU with the sensor inside the bondtech gears and without problems?

BastR · 2020-07-09T07:15:30Z

@isanval I think you should open a issues because the post is starting to be long, is not related to the PRUSA_MMU2S_MODE and may not be visible to users who could help you.

Plz post your configuration in the new issue too

tonihoang · 2020-07-09T07:30:16Z

Thanks @kakou-fr and @GMagician for your response. I'm using the bugfix version dated from 2020-06-27.

Maybe I'm missing something, but the problem here is that when MMU is executing the C0 command the printer extruder is not spining, so the MMU unit is not able to push the filament into the extruder (it has no enough torque for that).

From my point of view, the solution would be to spin slowly the extruder gear while MMU is executing the C0 command and until the filament inside the bondtech gears is triggered. From my understanding, this is how MK3S/MMU2S works.

I'm doing something wrong? Is someone using the MMU with the sensor inside the bondtech gears and without problems?

it does work for me for some filaments, that's why i stopped, but I did think about the problem you mention, so I was already thinking about how to do it but since noone mentioned it, i did not do anything.

if you open a new FR I can create a PR when I find some time.

isanval · 2020-07-09T07:56:44Z

@tonihoang nice, thank you! I will open a FR, no problem (#18599). I was trying to code it myself, but I'm not used to Marlin neither I know the available functions, so it's really difficult to me.

Thanks

Toni Hoang added 2 commits April 13, 2020 14:57

Added initial version of MMU2S feature

9bd5c25

fixed default settings

d1992f6

thinkyhead and others added 3 commits April 13, 2020 14:22

Update mmu2.cpp

e5f1d32

Update SanityCheck.h

278ec21

added can_load function

425badc

thinkyhead added 4 commits April 13, 2020 22:15

Update Configuration_adv.h

aeaf35f

Update mmu2.cpp

29d28fe

Update mmu2.cpp

2946b91

Update Configuration_adv.h

22545f5

thinkyhead added C: Peripherals PR: New Feature labels Apr 14, 2020

Toni Hoang added 4 commits April 14, 2020 10:49

initial integration of can_load() and some more configuration variables

5f075f4

add missing #endig

463153a

missed a _ in variable

3d444fa

removed additional )

5546eac

tonihoang marked this pull request as ready for review April 14, 2020 10:01

thinkyhead and others added 5 commits April 14, 2020 16:35

Update Configuration_adv.h

8f797b3

Add test for PRUSA_MMU2_S_MODE

9f10531

Add "MMU" to some MMU strings

8b99923

Update test

23dc87f

forgot to add during tool change

c8f5515

Merge branch 'bugfix-2.0.x' into bugfix-2.0.x

a278c6b

Merge branch 'bugfix-2.0.x' into bugfix-2.0.x

7c8be91

thinkyhead merged commit 21067ab into MarlinFirmware:bugfix-2.0.x Apr 26, 2020

GMagician reviewed Apr 26, 2020

View reviewed changes

BastR mentioned this pull request May 5, 2020

Add extruder sensor for MMU2 #17886

Merged

tonihoang deleted the bugfix-2.0.x branch July 9, 2020 07:31

isanval mentioned this pull request Jul 9, 2020

[FR] PRUSA_MMU2_S_MODE enhacement, spin the BMG gears while C0 command #18599

Closed

jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this pull request Aug 7, 2020

Add Prusa MMU2S settings - beta (MarlinFirmware#17523)

4d97021

njibhu pushed a commit to njibhu/Marlin that referenced this pull request Aug 24, 2020

Add Prusa MMU2S settings - beta (MarlinFirmware#17523)

5b4157e

HairingX pushed a commit to HairingX/Marlin that referenced this pull request Jun 16, 2021

Add Prusa MMU2S settings - beta (MarlinFirmware#17523)

c990eb1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added initial version of MMU2S feature #17523

Added initial version of MMU2S feature #17523

tonihoang commented Apr 13, 2020

vertigo235 commented Apr 13, 2020

tonihoang commented Apr 13, 2020 •

edited

Loading

BastR commented Apr 13, 2020 •

edited by thinkyhead

Loading

vertigo235 commented Apr 13, 2020 •

edited

Loading

tonihoang commented Apr 13, 2020

tonihoang commented Apr 14, 2020 •

edited

Loading

BastR commented Apr 14, 2020

tonihoang commented Apr 14, 2020

BastR commented Apr 14, 2020

BastR commented Apr 21, 2020 •

edited by thinkyhead

Loading

tonihoang commented Apr 21, 2020 •

edited by thinkyhead

Loading

tonihoang commented Apr 22, 2020

BastR commented Apr 22, 2020 •

edited by thinkyhead

Loading

GMagician Apr 26, 2020 •

edited

Loading

isanval commented Jul 6, 2020

GMagician commented Jul 6, 2020

isanval commented Jul 6, 2020

GMagician commented Jul 6, 2020 •

edited

Loading

isanval commented Jul 6, 2020 •

edited

Loading

GMagician commented Jul 6, 2020

isanval commented Jul 7, 2020

isanval commented Jul 8, 2020

kakou-fr commented Jul 8, 2020

GMagician commented Jul 8, 2020

isanval commented Jul 9, 2020

BastR commented Jul 9, 2020

tonihoang commented Jul 9, 2020

isanval commented Jul 9, 2020

Added initial version of MMU2S feature #17523

Added initial version of MMU2S feature #17523

Conversation

tonihoang commented Apr 13, 2020

Requirements

Description

Benefits

Related Issues

vertigo235 commented Apr 13, 2020

tonihoang commented Apr 13, 2020 • edited Loading

BastR commented Apr 13, 2020 • edited by thinkyhead Loading

vertigo235 commented Apr 13, 2020 • edited Loading

tonihoang commented Apr 13, 2020

tonihoang commented Apr 14, 2020 • edited Loading

BastR commented Apr 14, 2020

tonihoang commented Apr 14, 2020

BastR commented Apr 14, 2020

BastR commented Apr 21, 2020 • edited by thinkyhead Loading

tonihoang commented Apr 21, 2020 • edited by thinkyhead Loading

tonihoang commented Apr 22, 2020

BastR commented Apr 22, 2020 • edited by thinkyhead Loading

GMagician Apr 26, 2020 • edited Loading

Choose a reason for hiding this comment

isanval commented Jul 6, 2020

GMagician commented Jul 6, 2020

isanval commented Jul 6, 2020

GMagician commented Jul 6, 2020 • edited Loading

isanval commented Jul 6, 2020 • edited Loading

GMagician commented Jul 6, 2020

isanval commented Jul 7, 2020

isanval commented Jul 8, 2020

kakou-fr commented Jul 8, 2020

GMagician commented Jul 8, 2020

isanval commented Jul 9, 2020

BastR commented Jul 9, 2020

tonihoang commented Jul 9, 2020

isanval commented Jul 9, 2020

tonihoang commented Apr 13, 2020 •

edited

Loading

BastR commented Apr 13, 2020 •

edited by thinkyhead

Loading

vertigo235 commented Apr 13, 2020 •

edited

Loading

tonihoang commented Apr 14, 2020 •

edited

Loading

BastR commented Apr 21, 2020 •

edited by thinkyhead

Loading

tonihoang commented Apr 21, 2020 •

edited by thinkyhead

Loading

BastR commented Apr 22, 2020 •

edited by thinkyhead

Loading

GMagician Apr 26, 2020 •

edited

Loading

GMagician commented Jul 6, 2020 •

edited

Loading

isanval commented Jul 6, 2020 •

edited

Loading