-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init all ESP01 WIFI pins (ESP01 module) #17679
Init all ESP01 WIFI pins (ESP01 module) #17679
Conversation
Per PR #17531, we've now seen one ESP01/motherboard combo that requires explicitly driving the four pins for proper operation. |
Error introduced by PR MarlinFirmware#17248
Thanks, this PR allows me to actually use my ESP01S on SKR Pro ;-) |
7b92348
to
37176ed
Compare
Guesed wrong as to which of the duplicates would be deleted.
Switched to the latest language_de.h. Previously guessed wrong as to which of the duplicate defines would be kept. |
Could you outline the steps needed to get this working on the SKR PRO? Trying to get this working myself. Thanks! |
@DroneMang sure ;-) Most difficult part was to get ESP3D running on the ESP01S; I was following https://github.com/luc-github/ESP3D/wiki/Install-Instructions However w/o this PR the ESP01S wasn't working when it was plugged (but working fine otherwise). It's working fine now with this PR merged. |
On the ESP01 WIFI module the GPIO0 and GPIO2 pins can be left open and the module will still operated properly. This is because the ESP3D software configures the GPIO0 and GPIO2 pins as inputs with pullups.
This PR gives the user the option of explicitly driving these pins high.
This PR is strictly a defensive move in case the WIFI module's software is changed or we run into a motherboard that doesn't follow convention.The module will operate normally if the RESET pin is also left open. I never did find primary source documentation stating this was OK.
FYI - ESP_WIFI_MODULE_COM and ESP_WIFI_MODULE_BAUDRATE defines in the pins_YOUR_BOARD.h file don't actually do anything. Their only purpose is to inform/remind the user.