-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mesh bed leveling: Added G29 S3 + finer display steps during manual input + bug fix #1774
Conversation
* Use "G29 S3 Xn Yn Zn.nn" to modify bad probed point manually * Changed manual Z steps from 0.05 to 0.025 and made brought it to Configuration.h
#if defined(MANUAL_BED_LEVELING) | ||
#define MBL_Z_STEP 0.025 | ||
#endif // MANUAL_BED_LEVELING | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add these lines to all the other Configuration.h
files and this can be merged. It's a clean PR and a feature that doesn't interact with others, so I have no worries about new bugs with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oki! gonna try to get that done.
Oops, I stepped on your PR with recent changes, probably mostly to the Configurations. Try merging the latest Development into your branch and hopefully it's a quick-fix. |
Conflicts: Marlin/Configuration.h Marlin/Marlin_main.cpp
Think I fixed all that, example Configuration's + merge conflicts, and a bug I found too. But don't know why github isn't picking up these changes?! |
Now it looks like github finally got it! :) |
Wish I could merge it now, but we've got more bugs to fix first. Soon… |
#ifdef MESH_BED_LEVELING | ||
#error Select 'ENABLE_AUTO_BED_LEVELING' or 'MESH_BED_LEVELING', not both | ||
#endif // MESH_BED_LEVELING | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests should really be moved to SanityCheck.h
. There might be other MESH_BED_LEVELING
stuff in there already.
#ifdef MESH_BED_LEVELING
#ifdef DELTA
#error MESH_BED_LEVELING does not yet support DELTA printers
#endif
#ifdef ENABLE_AUTO_BED_LEVELING
#error Select ENABLE_AUTO_BED_LEVELING or MESH_BED_LEVELING, not both
#endif
#endif
This makes it easier to manage sanity checking, as these tests don't have to be copied to all the example configs, but just live in one single file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, will try to move it there.
Mesh bed leveling: Added G29 S3 + finer display steps during manual input + bug fix
Added G29 S3 to be able to tweak single bad probed points manually. Also added a config variable to set the step length used when manually probing by the display.