Enable BigTreeTech GTR onboard I2C EEPROM by default #18029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: NAPCAL <47440988+NAPCAL@users.noreply.github.com>
thisiskeithb
force-pushed
the
pr/fix_btt_gtr_eeprom
branch
from
f96fd17
to
9228c33
Compare
|
I'm working on replacing use of |
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
May 29, 2020
4 tasks
jmp0x0000
pushed a commit
to jmp0x0000/Marlin
that referenced
this pull request
Aug 7, 2020
HairingX
pushed a commit
to HairingX/Marlin
that referenced
this pull request
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The BigTreeTech GTR ships with a real/onboard EEPROM, so this PR enables it by default. Based on GTR pin file from the official GTR repo.
I bench tested a GTR with these changes and EEPROM settings were saved/retrieved/reset successfully, but it has been reported to work successfully in the GTR Facebook group as well.
Also:
#undef E2ENDwas used, otherwise there'd be a ton of redefined warnings.Benefits
Use onboard/real EEPROM on the GTR.
Related Issues